Giter Site home page Giter Site logo

Comments (3)

jumbojett avatar jumbojett commented on July 18, 2024

@screambeard thank you so much for raising this. Feel free to submit a PR. Both seem logical @rasodu @jricher @screambeard which option would you vote?

from openid-connect-php.

screambeard avatar screambeard commented on July 18, 2024

my apologies, it's been a while. however, i've been thinking about this and would suggest the following method:

  • add a function to add extra provider urls. similar to the addScope function. this extra provider urls will only be used in the verifyJWTclaims function

  • in the verifyJWTclaims function check if the $claims->iss with is in the array which consist of: the standard providerUrl and the extraProviderUrls.

My reasoning is the following:

  • the application should work the same for all other providers
  • the user using the package should be aware of adding an extra providerUrl and the risk

What do you think @rasodu @jricher @jumbojett ?

If you agree I will make a pull request this week

from openid-connect-php.

svrooij avatar svrooij commented on July 18, 2024

How about just creating an array of expected issuers, check with that and throw an error is the issuer is not in the array? That is the recommended way to validate JWT tokens anyway.

from openid-connect-php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.