One-time, double-loading of ftplugin files on FT-based ODL

[junegunn]

One-time, double-loading of ftplugin files on FT-based ODL

[junegunn]

Without preceding filetype plugin indent on

• plug#end()
  • Load ftdetect
  • au PlugLOD FileType xxx call s:lod_ft('xxx', 'vim-xxx')
  • filetype plugin indent on
    • au filetypedetect BufNewFile,BufRead ...
    • au filetypeplugin FileType * call s:LoadFTPlugin()
    • au filetypeindent FileType * call s:LoadIndent()
• Open xxx
  • ftdetect
  • PlugLOD
    • Add plugin path to &rtp
    • Load plugin and after/plugin
  • filetypeplugin
    • Load ftplugin
  • filetypeindent
    • Load indent

All is well.

With preceding filetype plugin indent on

• /etc/vimrc
  • filetype plugin indent on
    • au filetypedetect BufNewFile,BufRead ...
    • au filetypeplugin FileType * call s:LoadFTPlugin()
    • au filetypeindent FileType * call s:LoadIndent()
• plug#end()
  • Load ftdetect
  • au PlugLOD FileType xxx call s:lod_ft('xxx', 'vim-xxx')
  • filetype plugin indent on
    • did_load_filetypes
    • did_load_ftplugin
    • did_indent_on
• Open xxx
  • ftdetect
  • filetypeplugin
    • Load ftplugin
  • filetypeindent
    • Load indent
  • PlugLOD
    • Add plugin path to &rtp
    • Load plugin and after/plugin

Files under ftplugin are not loaded as &rtp is not yet updated.

Removing filetypeplugin autocmd

• /etc/vimrc
  • filetype plugin indent on
    • au filetypedetect BufNewFile,BufRead ...
    • au filetypeplugin FileType * call s:LoadFTPlugin()
    • au filetypeindent FileType * call s:LoadIndent()
• plug#end()
  • Load ftdetect
  • au PlugLOD FileType xxx call s:lod_ft('xxx', 'vim-xxx')
  • au! filetypeplugin *, unlet did_load_ftplugin, ...
  • filetype plugin indent on
    • did_load_filetypes
    • au filetypeplugin FileType * call s:LoadFTPlugin()
    • au filetypeindent FileType * call s:LoadIndent()
• Open xxx
  • ftdetect
  • PlugLOD
    • Add plugin path to &rtp
    • Load plugin and after/plugin
  • filetypeplugin
    • Load ftplugin
  • filetypeindent
    • Load indent

Reissuing autocmds (current solution)

• /etc/vimrc
  • filetype plugin indent on
    • au filetypedetect BufNewFile,BufRead ...
    • au filetypeplugin FileType * call s:LoadFTPlugin()
    • au filetypeindent FileType * call s:LoadIndent()
• plug#end()
  • Load ftdetect
  • au PlugLOD FileType xxx call s:lod_ft('xxx', 'vim-xxx')
  • filetype plugin indent on
    • did_load_ftplugin
    • did_load_filetypes
    • did_indent_on
• Open xxx
  • ftdetect
  • filetypeplugin
    • Load ftplugin
  • filetypeindent
    • Load indent
  • PlugLOD
    • Add plugin path to &rtp
    • Load plugin and after/plugin
    • doautocmd filetypeplugin FileType
      • Load ftplugin
    • doautocmd filetypeindent FileType
      • Load indent

[junegunn]

There were some errors in the description.
Due to the commit 7f1ec7b, autocmd appearing before plug#end() will be invoked before ftplugin. This behavior is consistent regardless of whether filetype plugin indent on is called before plug#end() or not. So if you want to override ftplugin defaults, make sure to put autocmd after plug#end() call.

---

• With filetype plugin indent on before plug#end()
  • ftplugin (by s:lod_ft)
  • vimrc autocmd
• Without filetype plugin indent on before plug#end()
  • ftplugin
  • ftplugin (by s:lod_ft, redundant)
  • vimrc autocmd

Most ftplugins have b:did_ftplugin guard, so loading it again should be fine. 😐