Console launcher should support `--version`

[sormuras]

Console launcher should support `--version`

[sormuras]

Looks very good to me!

java -jar junit-platform-console-standalone-1.11.0-20240516.144734-223.jar --version

JUnit Platform Console Launcher 1.11.0-SNAPSHOT
JVM: 23-ea (Oracle Corporation OpenJDK 64-Bit Server VM 23-ea+21-1723)
OS: Windows 11 10.0 amd64

[sbrannen]

@sormuras, can you please create a new issue to address that in 5.11 M3?

[marcphilipp]

There's support for version options in Picocli: https://picocli.info/#_version_help

[sormuras]

Related option already in place: --list-engines

• #2789

[sormuras]

However, running junit on the module path does not look so good to me.

org.junit.platform.console/[email protected] --version

JUnit Platform Console Launcher null
JVM: 22.0.1 (Oracle Corporation OpenJDK 64-Bit Server VM 22.0.1+8-16)
OS: Windows 11 10.0 amd64

This

junit5/junit-platform-console/src/main/java/org/junit/platform/console/options/ManifestVersionProvider.java

Line 18 in f82aefa

return ManifestVersionProvider.class.getPackage().getImplementationVersion();

returns null.

We should fist try a ModuleVersionProvider on Java 9+, like we do here:

junit5/junit-platform-engine/src/main/java/org/junit/platform/engine/TestEngine.java

Lines 184 to 195 in f82aefa

	default Optional<String> getVersion() {
	Optional<String> standalone = PackageUtils.getAttribute(getClass(), "Engine-Version-" + getId());
	if (standalone.isPresent()) {
	return standalone;
	}
	String fallback = "DEVELOPMENT";
	Optional<String> moduleVersion = ModuleUtils.getModuleVersion(getClass());
	if (moduleVersion.isPresent()) {
	return moduleVersion;
	}
	return Optional.of(PackageUtils.getAttribute(getClass(), Package::getImplementationVersion).orElse(fallback));
	}

And resort to a non-null fallback value.