Giter Site home page Giter Site logo

Comments (7)

parente avatar parente commented on June 9, 2024

It's more likely than not our bug since we don't have good (any?) test coverage (manual or automated) on Windows.

I thought we were duplicating what the other jupyter projects do to install their bin scripts and make them accessible under the jupyter <something> command. But I suspect we're missing a step to make it work on Windows specifically. (They work fine on Linux and OS X.)

from kernel_gateway.

parente avatar parente commented on June 9, 2024

Evidence: https://github.com/jupyter/nbconvert/blob/master/setup.py#L191

from kernel_gateway.

parente avatar parente commented on June 9, 2024

@ChristophLo I think I've got the exe problem fixed for Windows, but I'm having a heck of a time getting a Windows VM setup to test it. If you're familiar with testing pull requests, it might speed things along if you could pull and try the one associated with this work item. If not, don't worry about it: I'll get it setup sooner or later.

from kernel_gateway.

ChristophLo avatar ChristophLo commented on June 9, 2024

I'll try...

from kernel_gateway.

ChristophLo avatar ChristophLo commented on June 9, 2024

The current fork bdist-wheel including the changes you made one hour ago does indeed install and de-install correctly in windows (deinstalled my old kernel-gateway, removed the files I created manually, installed via pip locally using the aforementioned fork which did indeed create the required .exe files, and deinstalled again which removed the .exe files).
So, the issue seems to be fixed.

from kernel_gateway.

parente avatar parente commented on June 9, 2024

Awesome. Thanks for testing it so quickly! I'll get it merged.

from kernel_gateway.

ChristophLo avatar ChristophLo commented on June 9, 2024

Thanks for fixing!

from kernel_gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.