Giter Site home page Giter Site logo

Comments (6)

Zsailer avatar Zsailer commented on September 23, 2024 2

@chiawchen and @kevin-bates, great stuff here! Thank you for reporting and fixing this bug so quickly!

I'll make a new release now.

from synchronizer.

welcome avatar welcome commented on September 23, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

from synchronizer.

kevin-bates avatar kevin-bates commented on September 23, 2024

Hi @chiawchen - thanks for opening this issue. Looks like the list_sessions() call inadvertently included self over the course of the changes for #22 and #26. Is this something you'd like to make a quick PR for?

from synchronizer.

kevin-bates avatar kevin-bates commented on September 23, 2024

@Zsailer - FYI - I directed @chiawchen to this repo because they're interested in a form of "client-side HA" where they may want to update the client packages (bring down lab, refresh, restart lab, and reconnect to the persisted sessions that will be serviced by a gateway server). I couldn't recall if this particular scenario can be detected and recovered from with the synchronizer - but I suspect it can.

from synchronizer.

chiawchen avatar chiawchen commented on September 23, 2024

sure thing! just add a small fix on it

from synchronizer.

kevin-bates avatar kevin-bates commented on September 23, 2024

Addressed via #42

from synchronizer.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.