Comments (7)
@certik @TobiasWallner Should be fixed now
from cpp-terminal.
I just tried it and it works like a charm again, thx
from cpp-terminal.
@certik @TobiasWallner I fully agree with all your comments. Sorry for this stupid change, will move back to string
from cpp-terminal.
That code:
m_Type = Type::CopyPaste;
m_container.m_string.reset(new char[str.size() + 1]);
std::copy(str.begin(), str.end(), m_container.m_string.get());
m_container.m_string.get()[str.size()] = '\0';
return;
should not be written like this. First of all, one should not use "new" by hand like this, since it usually leads to leaks and segfaults, possibly even causing the issue that you've seen. Second, as you said, this doesn't seem efficient. Why can't we simply append to the string?
from cpp-terminal.
Why can't we simply append to the string?
or assign
from cpp-terminal.
@flagarde awesome, thanks! No worries, this should be easy to fix.
from cpp-terminal.
I tested quickly on linux but please have a try too because string inside union it's a bit tricky
from cpp-terminal.
Related Issues (20)
- read_key0() exists in input.hpp but not in input.cpp HOT 4
- Color are wrong with unicode characters on Windows HOT 2
- Flickering HOT 20
- Windows terminal can be turned into `legacy mode` and so crash our ANSII support detection
- example 'kilo' does not support special characters HOT 7
- exception leaking destructor is dangerous HOT 10
- build as shared library, error adding symbols: DSO missing from command line HOT 12
- Compiling the examples with GCC results in errors HOT 7
- Create a list of projects that are using this library HOT 3
- Bug: cpp-terminal crashes if two utf8 are inserted simultaneously HOT 42
- Multiline prompt stopped working on macOS
- Ctrl + I and Tab HOT 6
- Bug: Text Wrap Incompatibility HOT 6
- Bring back the list of other similar libraries HOT 4
- Pressing Ctrl, Alt, Shift creates a copy paste event on windows? HOT 3
- Addition of Metakey and Key results in warning of deprecation HOT 1
- Bug in key + metakey arithmetic HOT 7
- mouse sending random characters to the terminal after examples/minimal ends HOT 8
- `std::cin` doesn't read pipe redirection HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpp-terminal.