Overriding CMAKE_CXX_FLAGS_DEBUG may cause link error in MSVC

[jupyter-xeus]

Overriding CMAKE_CXX_FLAGS_DEBUG may cause link error in MSVC

[SylvainCorlay]

Hey @myd7349, thanks for working on the xeus vcpkg package!

Indeed we are never building xeus in debug mode in our CI. I will look into this.

[myd7349]

@SylvainCorlay Thanks for your fast reply!

The command line option -DCMAKE_BUILD_TYPE=Debug here is important to reproduce this issue. Otherwise, CMAKE_BUILD_TYPE contains an empty value and the CMAKE_CXX_FLAGS_DEBUG overriding will be skipped.

Thanks again!

:-)

[SylvainCorlay]

I think that the reason for this is that in

https://github.com/QuantStack/xeus/blob/0.18.1/CMakeLists.txt#L198-L201

we actually override the default behavior so that even for a DEBUG build of xeus, we link with the release builds of the dependencies.

[SylvainCorlay]

Completely removing these lines should fix the issue.

Just had a quick chat with @JohanMabille about this. (He used it to debug on windows without having to build dependencies in debug mode).

We both think this should remove this completely.

[SylvainCorlay]

Could you check that removing it fixes your issue? We would be glad to accept such a PR if it does.

[myd7349]

@SylvainCorlay Thanks.

Yeah. I fixed this issue in a similar way before (https://github.com/Microsoft/vcpkg/pull/5351/files#diff-1ea5275a34978a592706e189515f71a1), and it worked for me.

[myd7349]

It seems that cryptopp package installed via conda only contains a Release version of cryptopp-static.lib. So this line

message(STATUS "Forcing tests build type to Release")
set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE)

in test\CMakeLists.txt is important. Otherwise, the CI will fail.