Giter Site home page Giter Site logo

Comments (5)

mathbunnyru avatar mathbunnyru commented on June 3, 2024 2

Hey @mathbunnyru! Just wanted to report that we just deployed the new 2024-01-08 tag in our Swarm cluster and the healthcheck script is working perfectly with customised runtime dir now! 🎉

Thanks for the update, I'm glad everything works for you 🙂

Thanks for the quick review and tag update! Really appreciate the work you do with these images.

Thank you ❤️ Please, consider sponsoring my work (I do not insist, though) 🙂

from docker-stacks.

mathbunnyru avatar mathbunnyru commented on June 3, 2024 1

Hi @hhromic! Thank you for such a detailed issue - you've done a great job investigating this issue.

If you agree with the above, I can send a PR with this fix.

I do agree and your solution seems to be reasonable.
Also, please, include the test here: https://github.com/jupyter/docker-stacks/blob/main/tests/base-notebook/test_healthcheck.py I think you will only need to add one line of code to this test file.

from docker-stacks.

hhromic avatar hhromic commented on June 3, 2024

The workaround we are using for now is to disable healthchecks in the compose file. For example:

services:
  notebook:
    image: quay.io/jupyter/scipy-notebook:2023-12-25
    healthcheck:
      disable: true

from docker-stacks.

hhromic avatar hhromic commented on June 3, 2024

@mathbunnyru done!
Let me know what do you think in the PR itself.
Happy to help to this nice project 👍.

from docker-stacks.

hhromic avatar hhromic commented on June 3, 2024

Hey @mathbunnyru!
Just wanted to report that we just deployed the new 2024-01-08 tag in our Swarm cluster and the healthcheck script is working perfectly with customised runtime dir now! 🎉

Thanks for the quick review and tag update! Really appreciate the work you do with these images.

from docker-stacks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.