Comments (3)
I don't feel moving away from docker-py is urgent, unless something changes, like:
- A critical CVE in docker-py that can't be mitigated by a change to DockerSpawner
- Incompatibility with a newer version of Docker, Python, or a docker-py dependency
However, it does seem like an issue to have on the radar so that it's not a surprise if docker-py can't be used, or if there's an opportunity to make a change with other benefits. And I am too unfamiliar with Docker to say whether a CLI wrapper library would be the better solution, I was just glad to have something to list under alternative options.
from dockerspawner.
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋
Welcome to the Jupyter community! 🎉
from dockerspawner.
Switching to the docker CLI would also mean the podman CLI should mostly just work 😃
https://gabrieldemarmiesse.github.io/python-on-whales/#main-features claims
1 to 1 mapping between the CLI interface and the Python API.
There's a couple of Podman CLI spawners intended to get the benefits of daemon-less root-less containers.
- https://github.com/gatoniel/podmanspawner
- https://github.com/manics/podmanclispawner
I've also written a Podman CLI backend for repo2docker: - https://github.com/manics/repo2podman
So I don't think switching to a CLI wrapper (either our own or python-on-whales) is too difficult. It's a question of is it worth it and if so, how soon is it needed? It's obviously best not to use an unmaintained package, but there's only one CVE for docker-py from 2014.
from dockerspawner.
Related Issues (20)
- Spawned container network settings not populated
- "host" network_mode is incompatible with port_bindings HOT 2
- Extra Create Kwargs Overwrite Create Kwargs HOT 2
- Named server docs do not include information on `name_template` configuration HOT 3
- SQLAlchemy 2 compatibility issue with JupyterHub<3.0 HOT 3
- Discussion: SQLAlchemy2 compatibility issue HOT 8
- imagename and tag not sanitized in name_template HOT 2
- Unable to change docker container name HOT 3
- Podman tests fails in CI due to restricted permissions in podman service started by non-root user HOT 1
- Not able to log to jupyterhub notebook as admin HOT 3
- Escape defaults causing mixed case usernames to have problems with the SystemUserSpawner HOT 2
- Add docs url to the right side of GitHub repo HOT 2
- Running SwarmSpawner with `c.SwarmSpawner.extra_create_kwargs = {"user": "root"}` fails HOT 1
- Allow passing exposed port arguments to docker swarm service creation HOT 3
- Interesting link in singleuser container HOT 2
- Add implementation for delete_forever HOT 1
- Test failures in main branch
- Request for image pull secrets to be passed for docker spawner single user image HOT 4
- Jupyterhub sample /examples/oauth not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dockerspawner.