Comments (8)
Thanks! OK, I may actually have gotten it working with websockets too. Now to test some more and clean up!
from jupyter-server-proxy.
Heya! Good question! I don't see why not. We can have a 'https' field in the config that can be set to 'true' optionally to support https. Would love patches! :)
from jupyter-server-proxy.
Hi @ChandaniM123 @yuvipanda I think we need to do this too. I'm thinking should we actually have configuration options for key, cert, and CA?
from jupyter-server-proxy.
@rcthomas Yeah, that sounds like a good way to do that. Happy to review a PR
from jupyter-server-proxy.
Hey @yuvipanda I've made some progress on the HTTP handlers. I can at least make the proxy talk to various Dask components over SSL. It's not perfect but I think the remaining issue I have there on the HTTP handler side I will be able to work out. (Some certificate verification problem on the Dask dashboard.)
I'm also wondering if we should set up the default to be a check for the internal SSL components from JupyterHub. That is, something like:
keyfile = Unicode(
os.getenv("JUPYTERHUB_SSL_KEYFILE", ""),
help="SSL key, use with certfile",
config=True
)
This may be a too-complicated default. A user could simply put that os.getenv() into their config, instead of us deciding for them that the above default scheme is the way they should be doing it.
The more looming thing is the websocket handler stuff, it's failing right now which I expected, and I am wondering if you had any pointers or orientation on the websocket side of things that it would be good to know before I start hacking.
from jupyter-server-proxy.
Yeah, I think to begin with asking users to put os.getenv is probably the way to go.
I think @ryanlovett added most of the websocket stuff, so might have more pointers.
I am very excited you are working on this, @rcthomas!
from jupyter-server-proxy.
@rcthomas What is the status of this issue ? Are you still working on itβ―?
from jupyter-server-proxy.
@PhML no, and I think the reason I stopped pushing is that my motivating use cases evaporated. Not sure whether anyone else wants to pick it up and carry it forward, I am sure the PR I submitted is out of date. More sets of eyes on what was wrong there might help.
from jupyter-server-proxy.
Related Issues (20)
- labextension support on jupyterlab >= 4.0 HOT 2
- JupyterLab extension to also be a Notebook 7 extension
- Test failures with JupyterLab 3 - soon resolved upstream HOT 1
- Do we need .yarnrc, or can we always build the extension with jupyterlab 4 that doesn't need it? HOT 3
- Resolve consistent failures related to "address in use" etc HOT 1
- Test suite is failing in main branch
- Test suite failing in our CI system HOT 1
- Error 500 when using Jupyter Server Proxy Arbitrary Ports on a port that is not serving HOT 1
- Handler subprotocol method fails to detect empty list HOT 1
- PDF preview of LaTeX Workshop (code-server) results in `HTTP 400: Bad Request` HOT 4
- Test failures in main branch HOT 4
- WebSocket subprotocols for client/proxy are chosen without asking the server we proxy to HOT 10
- Issue on page /install.html HOT 1
- Consider changing or removing Author field from PyPI
- Require at least tornado 6.1 - a dependency for notebook 6.2+ and jupyterlab 3+
- Open in Panel HOT 3
- `new_browser_tab` is True by default, but documented to be False
- Ability to Configure Activity Reporting HOT 1
- Document `rewrite_response`
- Process management and the ability to start and stop the launched process HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jupyter-server-proxy.