Comments (3)
Hey this is a great idea! I'm curious - do you think relative URL paths would be good, or do you think it would be better to translate this back into the local file path? For instance this:
[200] http://localhost:5259/css/site.css
[200] http://localhost:5259/manifest.json
[200] http://localhost:5259/about/
[200] http://localhost:5259/2019/12/18/package-lock/
[200] http://localhost:5259/archive/
Could become this:
[200] /css/site.css
[200] /manifest.json
[200] /about/
[200] /2019/12/18/package-lock/
[200] /archive/
Or we could show the relative path to the file on the file system (I think I can do that...):
[200] ./css/site.css
[200] ./manifest.json
[200] ./about/index.html
[200] ./2019/12/18/package-lock/index.html
[200] ./archive/index.html
Or an absolute path to the file on the filesystem:
[200] /Users/beckwith/Code/mysite/css/site.css
[200] /Users/beckwith/Code/mysite/manifest.json
[200] /Users/beckwith/Code/mysite/about/index.html
[200] /Users/beckwith/Code/mysite/2019/12/18/package-lock/index.html
[200] /Users/beckwith/Code/mysite/archive/index.html
I do think you have a really good point, and at the very least I'm going to start with trimming the host from the path
from linkinator.
My Idea was only based on making it simpler to read from the perspective of the person that authored the link in the site and then sees the output in the failed build's log. From that perspective /css/site.css
makes most sense to me.
I don't think the relative or absolute filesystem paths would be useful to me because I don't know a lot of scenarios any more where the HTML is authored by hand. To fix a link the author needs to mentally map to the respective source file (or CMS) convention anyways.
from linkinator.
The option that makes the most sense to me is paths relative to the root of the scan:
[200] css/site.css
[200] manifest.json
Starting with a slash feels technically wrong (that's an absolute path) and using an absolute path adds directories that aren't relevant to the user (Users, beckwith, etc.). The ./
option two comments above is second best in my mind: it's correct, but slightly more confusing as it requires the user to understand that syntax.
from linkinator.
Related Issues (20)
- Support for config in JS HOT 4
- False positives with v1.10.1? HOT 7
- Is there a way to see the page broken links exist on? HOT 3
- Where are the binary release downloads? HOT 1
- linkinator and curl disagree on link status HOT 1
- Support custom base path for local files
- Retry a gaxios request with new url HOT 2
- Excluding external URLs HOT 2
- Feature Request: concurrency per host HOT 3
- bug: path without trailing slash gets 404 error for relative links on page HOT 2
- npm audit fix causing unexpected token error HOT 1
- Request: Rate Limit
- How to run linkinator for "PUG" files HOT 3
- I have a website that needs authentication with username and password. Is it possible to authenticate a website and then run linkinator? HOT 2
- Skip links starting with http doesn't work
- local server: handling extensionless links
- meta http-equiv="refresh" redirects not being handled
- Same broken link in multiple files is being mentioned only once HOT 1
- Recursively crawling local directory for Markdown files fails HOT 1
- Debug output for CSV failureDetails column appears incorrect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linkinator.