Giter Site home page Giter Site logo

Comments (9)

punchcutter avatar punchcutter commented on May 23, 2024

How about using what fontTools does: https://github.com/mikekap/unicodedata2

from fontgoggles.

justvanrossum avatar justvanrossum commented on May 23, 2024

Thanks! I'll have a look at unicode2.

I know FG's BiDi support is "weak" to say the least, but this is rather embarrassing.

My approach to BiDi and use of the python-bidi package should be on its way out, though, once I figure out how to address #35 (see latest comments).

from fontgoggles.

justvanrossum avatar justvanrossum commented on May 23, 2024

I've updated the FG code to use unicodedata2, but that doesn't solve the bidi issue, as python-bidi uses the builtin module. I could fork python-bidi, but given the more radical changes needed to fix #35 I'm not sure if that's worth it. Alternatively I could monkeypatch bidi.algorithm.

from fontgoggles.

justvanrossum avatar justvanrossum commented on May 23, 2024

Ok, I did the monkeypatching. I can push a release for you to try this out, or can you run from the source?

from fontgoggles.

justvanrossum avatar justvanrossum commented on May 23, 2024

Pushed v1.1.1, containing these fixes.

from fontgoggles.

punchcutter avatar punchcutter commented on May 23, 2024

That looks good for the Unicode support side. Until next week when Unicode 13.0 is out and unicodedata2 needs to get updated again.

from fontgoggles.

justvanrossum avatar justvanrossum commented on May 23, 2024

Sure, I don't see how that can be avoided, though.

from fontgoggles.

punchcutter avatar punchcutter commented on May 23, 2024

Yes, nothing to avoid, just one of those things to keep in mind. Not that there will be a ton of people working on Unicode 13 fonts right now, but I'm working on a couple Unicode 12 fonts which is how I ran into this so fast.

from fontgoggles.

justvanrossum avatar justvanrossum commented on May 23, 2024

Thanks for the report, it's much appreciated. I'll close this now. Please open a new issue if you find more, or reopen if you find the current fix/workaround is insufficient.

from fontgoggles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.