Not distinguishing between left and right mouse clicks

[jvcleave]

Not distinguishing between left and right mouse clicks

[rjx-ray]

Now I have this code

		if (ImGui::IsItemHovered() && ImGui::GetIO().MouseClicked[1]) {
			ImGui::OpenPopupEx("Context menu", false);

Breaking on the second line
when I click the left button the MouseClicked array is [false,true,true,true,true]
when I click the right button the MouseClicked array is [false,true,false, false, false]

I believe the problem is here in line 147 of gui.cpp

			// Update for next frame; set to false only if the mouse has been released
			engine->mousePressed[i] = !engine->mouseReleased;

The state of buttons that were not pressed is inverted, so they go to true

changing line 147 to

if (engine->mousePressed[i]) engine->mousePressed[i] = !engine->mouseReleased;

fixes it and my original code now works.

I can make a pull request if you like.

[jvcleave]

Assuming you are building a Desktop app here is where we are passing the button info

https://github.com/jvcleave/ofxImGui/blob/master/src/EngineGLFW.cpp#L113

You should then check which button like this

if (ImGui::GetIO().MouseClicked[1])
{
    //do something
}

[rjx-ray]

I'm building and running on Windows 10.
I can see onMousePressed gets the right click event with button number 2, then translates it to 1 and it sets mousepressed[1] true;
So I need to check button 1 for the right click
But then my code is like this

		bool gotInput = (ImGui::InputText("", urlText, 1024, EnterForTrue));
		if (ImGui::BeginPopupContextItem("item context menu", 1)) 	{
			(ImGui::Selectable("Copy")) ;
			(ImGui::Selectable("Paste")) ;
			ImGui::EndPopup();
		}

and I get the popup for any mouse button.

Following the thread through, as soon as the field is hovered BeginPopupContextItem calls isMouseClicked which looks at IO.MouseDownDuration.
With no mouse clicks all 5 values are minus 1.
isMouseClicked only returns true if the requested button duration has a value of zero.

I put a break on the true return and then I see

If the left mouse button is clicked, the value for button[0] is a small positive number and all the others are zero so I get a true return for button[1] == 0

If the right mouse button is clicked, the value for button[1] is zero and all the others remain at minus 1 and I also get a true return button[1] == 0

I can see the code setting the MouseDownDurations at lines 2086 to 2089 of ImGui.cpp but I can't see why button 0 should work differently from button 1- maybe timing on when the break happens.

Anyway, I think I will make my own version of BeginPopupContextItem checking just MouseClicked

[jvcleave]

@rjx-ray rjx-ray@81c54a1 seems reasonable. A PR would be appreciated

[rjx-ray]

Hi Jason, I’m away for 2 weeks now so it will not happen till I get back. My fork also has the changes from issue #56 Would you want those? - Richard *From:* Jason Van Cleave [mailto:[email protected]] *Sent:* 30 June 2017 17:24 *To:* jvcleave/ofxImGui *Cc:* Richard Jackson; Mention *Subject:* Re: [jvcleave/ofxImGui] Not distinguishing between left and right mouse clicks (#55) @rjx-ray <https://github.com/rjx-ray> rjx-ray/ofxImGui@81c54a1 <rjx-ray@81c54a1> seems reasonable. A PR would be appreciated — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXvRt9lQkdCCGrvKZyhgwqcQH-c4tfQFks5sJSEGgaJpZM4OGs7W> .

[jvcleave]

no rush here. it seems like a simple tweak if someone needs it in the meantime

as for the clipboard changes that seems to be more complicated so it would probably be best at it's own PR

[rjx-ray]

Fixed in current master (1.65 imgui)