Change in calendar options does not get triggered after refresh

[jwgmeligmeyling]

Change in calendar options does not get triggered after refresh

[luigi37]

In effect with this code it seems to work:

    $("#calendar").data("jqm-calendar").settings.months=["Gennaio", "Febbraio", "Marzo", "Aprile", "Maggio", "Giugno", "Luglio", "Agosto", "Settembre", "Ottobre", "Novembre", "Dicembre"];
$("#calendar").data("jqm-calendar").settings.days=["Do", "Lu", "Ma", "Me", "Gi", "Ve", "Sa"];    
$("#calendar").trigger('refresh', new Date());

Except that the days do not get updated...

[jwgmeligmeyling]

I never thought of the use of refreshing the calendar for different translations. Both the start day of the week (eg. on sunday or monday) and the labels for the days are rendered in the init() function and not in the update function.

See: https://github.com/JWGmeligMeyling/jqm-calendar/blob/master/jw-jqm-cal.js#L80

I think it's quite easy to fix, but unfortunately I wont have the time for this now..

[luigi37]

Thanks, I will give it a try and if succesfull I'll commit the changes...
Do you mean I should move
the start day of the week (eg. on sunday or monday) and the labels for the days
to refresh() ?

[jwgmeligmeyling]

Yes I meant that, but I believe you already found out 😉

[luigi37]

I did not find an easy way to do that... thanks for any code change from your side :-)

[jwgmeligmeyling]

Then i'll reopen. Unfortunately I don't have the time to get involved on this issue now 😢

[luigi37]

Thanks a lot :-)

[luigi37]

Hi Jan, any update here? Got the first user noticing it :-) ...

[jwgmeligmeyling]

I would suggest just destroying the calendar and creating another one with the new settings object. I have no time to investigate this issue in the next few weeks.

[luigi37]

Hi Jan,
that would have created the need to reassociate the events and stuff I added....
I created a pull request which add an id to each day label and through that change it on the fly...
Let me know it ok and if you can merge
Thanks

[luigi37]

Change implemented