Giter Site home page Giter Site logo

Comments (4)

robwalch avatar robwalch commented on July 25, 2024

@kharri1073 can you provide a test page along with steps to reproduce. We have a few responsive tests and haven't encountered this behavior.

There are also several ways to configure how the player and media within the player scale, so including your player setup would be very helpful.

We've looked into replacing the scale-mode code in jw7 with CSS object-fit, but the browser coverage just isn't there yet http://caniuse.com/#feat=object-fit

Maybe object-fit'll do the trick for you. After we look at your setup we can maybe try one that disables transforms and lets you use CSS.

from jwplayer.

kharri1073 avatar kharri1073 commented on July 25, 2024

Thank you @robwalch. We have an old version of jw (v6.12) which is also affected. To test the letterboxed video, you can visit http://www.ora.tv/embed/0_vjup4bb6nbr. To test the our forked code, you can visit http://vpc-www-prod3.ora.tv/embed/0_vjup4bb6nbr.

We figured we would finally tackle this issue for preparation to upgrading our player to 7.1.

This behavior only occurs with <video> tags and not <object> tags.

from jwplayer.

robwalch avatar robwalch commented on July 25, 2024

@kharri1073 I'm getting the Flash player with that first url in Safari and Chrome because you're setting primary to "flash". If you turn that off, we should be able to look at the problem in Safari which can play your HLS stream natively.

You're not specifying a stretching option in your config. The default is uniform so that's fine. "uniform" seems to be the behavior you want. That would be the same as object-fit: contain; or background-size: contain;. We have not seen this issue in 7 or 6 so I'd try to make sure it's not related to your player container or maybe something specific to Safari which is quirky when it comes to transforms.

This shouldn't stop you from moving the jw7. If anything I'd hurry up and make the change. You'll find the code in stretch.js was modified quite a bit in jwplayer 7 to take advantage of our use of CSS in the player. We also continue to do the stretching in Flash in 7 when using an object tag. transforms are only applied to video tags to make up for object-fit support.

You can always set stretching to none in the config and apply it yourself, but then Flash will not stretch the way you want

stretching: "uniform", // setting this to "none" will prevent a transform scale from being set
aspectratio: "16:9",
width: "100%",
primary: "flash" // remove this

from jwplayer.

donato avatar donato commented on July 25, 2024

@kharri1073 - if you have any other questions feel free to re-open this ticket

from jwplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.