Comments (4)
Those newlines are giving me headaches, but for this the solutions seems to be simple enough. I'll scan the first file to detect the type of end-line and apply that to the join. I'll have a try at it this in the weekend.
from grunt-include-source.
I've improved the line endings for your use case, but it's untested. Could you confirm it works for you? Unit tests are required, I hope to add them eventually.
from grunt-include-source.
My issue was somehow similar to @ghwilson4456 problem, the lines that were joined were all \n instead of \r\n in windows. The problem is evident in these lines, https://github.com/jwvdiermen/grunt-include-source/blob/master/tasks/includeSource.js#L261-L264. After a line feed \n is detected, it decrements the index, the problem is at https://github.com/jwvdiermen/grunt-include-source/blob/master/tasks/includeSource.js#L262, wherein you check for the decremented index minus 1.
Change:
if (contents[i] === '\n'){
i--;
if (contents[i-1] === '\r'){
i--;
}
break;
}
to:
if (contents[i] === '\n'){
if (contents[--i] === '\r'){
i--;
}
break;
}
from grunt-include-source.
This should be fixed in the latest release.
from grunt-include-source.
Related Issues (20)
- Same source and destination file. HOT 3
- type="text/javascript" is redundant HOT 2
- Grunt's <%= %> feature is not supported HOT 2
- Ordering doesn't work HOT 2
- Stip of the last <include> block header when writing deps to the same file HOT 6
- why not include sources??? HOT 1
- Include sources in the same file HOT 2
- Includes duplicate JS files HOT 7
- Please support TypeScript template HOT 1
- How to include source maps (.map extension not supported)? HOT 1
- Include sources in js files HOT 3
- [Question] Targets, could be a folder and not a file HOT 1
- Overwrite not working
- Exclude paths HOT 1
- Warning: Symbol is not defined Use --force to continue. HOT 2
- Fails to include all files in <%= myFileList.js %> HOT 1
- TO DELETE
- script tag not included in html
- Adding support for JSP files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grunt-include-source.