Giter Site home page Giter Site logo

Comments (4)

jwvdiermen avatar jwvdiermen commented on July 2, 2024

Those newlines are giving me headaches, but for this the solutions seems to be simple enough. I'll scan the first file to detect the type of end-line and apply that to the join. I'll have a try at it this in the weekend.

from grunt-include-source.

jwvdiermen avatar jwvdiermen commented on July 2, 2024

I've improved the line endings for your use case, but it's untested. Could you confirm it works for you? Unit tests are required, I hope to add them eventually.

from grunt-include-source.

ryeballar avatar ryeballar commented on July 2, 2024

My issue was somehow similar to @ghwilson4456 problem, the lines that were joined were all \n instead of \r\n in windows. The problem is evident in these lines, https://github.com/jwvdiermen/grunt-include-source/blob/master/tasks/includeSource.js#L261-L264. After a line feed \n is detected, it decrements the index, the problem is at https://github.com/jwvdiermen/grunt-include-source/blob/master/tasks/includeSource.js#L262, wherein you check for the decremented index minus 1.

Change:

                if (contents[i] === '\n'){
                    i--;
                    if (contents[i-1] === '\r'){
                        i--;
                    }
                    break;
                }

to:

                if (contents[i] === '\n'){
                    if (contents[--i] === '\r'){
                        i--;
                    }
                    break;
                }

from grunt-include-source.

jwvdiermen avatar jwvdiermen commented on July 2, 2024

This should be fixed in the latest release.

from grunt-include-source.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.