Comments (2)
K-Sato1995
commented on July 28, 2024
Hi @jonpemby
Thanks for opening this issue!
it would make sense to rename SPELL_SET1 to SPELL_ADJECTIVES and perhaps SPELL_SET2 to SPELL_VERBS.
Definitely!! Those constants would be a lot more descriptive😄!!
We could also remove the class constants in favor of using SPELL_ADJECTIVES.size in the range
I totally agree with you here as well. That would make the code more intuitive and easier to read🙏!!
Are you interested in working on this??
from spell_generator.
jonpemby
commented on July 28, 2024
Sure @K-Sato1995! I opened a PR with my suggested changes. 😄
from spell_generator.
Related Issues (11)
- Add more spells
- Missing comma in README
- self_generate misuse should raise an Error
- Removing a noun from SPELL_VERBS
- Include the travis build status image in the README HOT 3
- Gemfile.lock isn't up to date, causing Travis Build to crash. HOT 1
- README link to CODE_OF_CONDUCT is broken.
- Reorganize words sets HOT 8
- Fix typos in README usage section HOT 6
- Given output does not match code execution in README usage section HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spell_generator.