Comments (23)
from composition-conditioned-crystal-gan.
@Z-Abbas https://figshare.com/s/350a8ac4732de2da3a00
from composition-conditioned-crystal-gan.
Hello! @syaym and @sgbaird
I have successfully run it from start to end using the VASP files.
At the end it generates "gen_images_x.npy" files.
Using this npy file (any single npy file) I run the below function inside view_atoms_mgmno.py;
def view_atoms_classifier(image,mg_label,mn_label, o_label, view=True):
When I print the atom, it gives me the output as:
Atoms(symbols='Mg4Mn4O', pbc=True, cell=[[6.622104644775391, 0.0, 0.0], [0.9188044602466798, 10.297901251162942, 0.0], [4.528352067461127, -7.3943218741460095, 15.134449311591837]])
and when I do "atoms.edit()" it generates the image in gui as attached.
@syaym Now I am wondering, how to check the validity of the generated atoms and convert it in structural form?
from composition-conditioned-crystal-gan.
So much hard code and no comments make the code difficult to use.
from composition-conditioned-crystal-gan.
@jhwann @syaym any update on this? Could really use some instructions and on your part make sure someone can actually run the code per the instructions without error (e.g. test by downloading a fresh copy from GitHub in a fresh conda environment).
from composition-conditioned-crystal-gan.
Regarding the training data, note that we have a separate routine for data pretreatments due to the capacity limit of this site to upload the entire data. I think you are likely running into a problem since you probably have not run that code needed for data pretreatments. So, I suggest you to run "5.make_comp_dict.py" ~ "7.make_label.py" in the preparing_dataset folder. Or, we now have uploaded the full data in a different website where you can download the trainable data already pretreated at https://figshare.com/s/0dce6bb830ae1e392206.
For the second question regarding the loss function of the classifier, the general form of L_class_atom has the lambda2*CE(A_gen, \hat(A_gen)) term, to be symmetric with L_class_comp, but the final value of lambda2 we used in the end is 0 instead of 1 to ensure structural diversity, and this is why the CE(Agen,\hat(A_gen)) term does not exist in the original code. Thus, in short, the hyperparameter for lambda2 in Table S1 in the SI file was a typo, and this correction is now in progress with the journal and will be updated shortly.
Many thanks for your comments.
(PS. The above reply is an edited/corrected version of my earlier response.)
from composition-conditioned-crystal-gan.
@syaym thank you for the response. I plan to give the code a try. Perhaps you could upload a copy of mgmno_2000.pickle
to figshare, assuming it it less than 20 GB, and then include the link in the README?
from composition-conditioned-crystal-gan.
Anyone, please guide, from where we can get the ".cif" and ".vasp" files?
@syaym are you going to upload the mgmno_2000.pickle file?
from composition-conditioned-crystal-gan.
@sgbaird @Z-Abbas I uploaded the mgmno_2000.pickle file.
from composition-conditioned-crystal-gan.
@syaym Wonderful. Thank you!
I see that you added the link to the README https://figshare.com/s/0dce6bb830ae1e392206
from composition-conditioned-crystal-gan.
@syaym Thank you for the file.
I am now able to run the "train.py" file after preparing the dataset by running "5.make_comp_dict.py" ~ "7.make_label.py". After running "train.py", it creates two folders; 1.model_cwgan_mgmno and 2. gen_image_cwgan_mgmno". The 2nd one contains the npy files which look like the screenshot attached.
Are these the x,y, and z-axis? How can I see the newly generated crystal-structues?
Would appreciate your earliest response.
from composition-conditioned-crystal-gan.
@Z-Abbas you may consider emailing @syaym
from composition-conditioned-crystal-gan.
@syaym Would you please guide me, how can I get the ".vasp" files for the below list?
vasp_list = glob.glob(vasp_path+'/*.vasp')
from composition-conditioned-crystal-gan.
@Z-Abbas In "preparing_dataset" folder, please run "5.make_comp_dict.py" ~ "7.make_label.py" for making data-augmented mgmno dataset. We provided 'unique_sc_mgmno.npy' instead of vasp files.
from composition-conditioned-crystal-gan.
@syaym Thank you for your prompt response.
I already have run 5~7. I just want to follow it from the start by importing the cif and vasp files. That's why I am looking for it. I already found the cif files but unable to find the vasp files.
from composition-conditioned-crystal-gan.
@syaym I would appreciate it if it's possible for you to share the vasp files.
from composition-conditioned-crystal-gan.
Much appreciated! Thank you!
from composition-conditioned-crystal-gan.
@Z-Abbas would be interested to hear back once you're able to get it running from start to finish using the VASP files
from composition-conditioned-crystal-gan.
@sgbaird sure :)
from composition-conditioned-crystal-gan.
@Z-Abbas I think that the generator is not fully trained enough for generating structures and you should run more training epochs.
from composition-conditioned-crystal-gan.
@syaym Thank you! and yes I reduced the n_epochs to 300 from 501(in code), and constraint_epoch to 5000(10000 in code). If I use the same epochs as in your code, will it generate the structures similar as given in paper?
And, am I correctly viewing the atoms using the "def view_atoms_classifier(image,mg_label,mn_label, o_label, view=True):" function?
from composition-conditioned-crystal-gan.
@Z-Abbas the structures in the paper were post-processed with DFT-optimization. Generated structures that have not undergone post-process may have the form of somewhat weird structures.
And, It is right to use "view_atoms_classifier "
from composition-conditioned-crystal-gan.
@syaym Thank you so much!
What about checking the validity of the generated molecules?
from composition-conditioned-crystal-gan.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from composition-conditioned-crystal-gan.