Giter Site home page Giter Site logo

Comments (1)

GreyCat avatar GreyCat commented on May 21, 2024

Try something like that:

meta:
    id: dat
    application: script
    endian: le
seq:
    - id: commands
      repeat: eos
      type: script_cmd
types:
    script_cmd:
        seq:
            - id: cmd_start
              contents: [0x23] 
            - id: num
              type: u2
            - id: params
              type: strz
              encoding: SJIS
              terminator: 0x23
              consume: false
              eos-error: false

That allows to parse the file you've provided without errors. However, it is still probably not a very good idea to parse the file using "parse anything up to 0x23" semantic - real parsing code rarely use something like that, and parsing params as a 0x23-terminated string is probably not what you want anyway.

In 99% of cases I've seen (with notable exception of terminator-based strings encoding), if we're dealing with something like a bytecode (i.e. [opcode] [parameters]), variable length parameters depend on the opcode itself, not the termination symbol. Notably, it's generally a very bad idea to add "termination bytes" like 0x23, given that some opcode might have genuine integer 0x23 as a parameter.

It is possible to implement something like "read bytes until some termination byte / sequence of bytes, and then reinterpret them as some complex subtype" in future, but so far I haven't seen a single example where such a semantic would be helpful. I'd be grateful if you'll prove me wrong :)

from kaitai_struct.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.