Comments (1)
Looks to me like a bug in FVTT. the "apply damages" appears if the content has an element with a dice-roll
class, but then it checks for dice-total
to apply, but since it doesn't find it, it will set the hp to null
(which is in itself a bug). I also can't change the span element to use a different class, because the CSS for the tooltip (which is generated by the core FVTT template) only applies to descendents of a dice-roll
class. So... potential fixes in FVTT :
- FVTT checks for existence of
dice-total
instead ofdice-roll
before deciding to show the 'apply damage' context menu - FVTT CSS for the roll tooltip should be using the selector
.dice-tooltip
and.dice-formula
instead of.dice-roll .dice-tooltip
and.dice-roll .dice-formula
- If more than 1 dice-total is found, the
Actor5e.ApplyDamages
should pop a notification asking the user which damage to use instead of concatenating their values - If resulting HP that gets calculated is not a valid number, it should not update the actor HP
- If a Bar attribute's value is non-valid (
null
in this case), the Token config sheet should not display that the selected attribute isNone
because it can confuse the user in thinking the bar setting changed when it's just its value that is not valid.
And for the actual fixes I'll want to do in Beyond20, it would be to add the dice-total
on the "Total Damage" line so it can be picked up and not have it set in attack/skills rolls for example
from beyond20.
Related Issues (20)
- Not able to roll Crits with Foundry native rolls HOT 3
- Custom modifier applied twice when applied to Druid Wildshape dice rolls HOT 1
- Using "add tiebreaker to initiative roll" should round extra floating point digits HOT 4
- Staff of Striking not sending attack from the Actions tab to Roll20 HOT 1
- Suggestion: Add "Max Normal Damage" as a Critical damage option HOT 4
- Track health (and other attributes) in Token Bars HOT 2
- Rage damage not being added to custom attacks HOT 2
- Native rolls not working with V11 Foundry and DND 2.3.0 HOT 7
- Chat errors on character inputs HOT 4
- Blood Curse of the eyeless bug (Blood hunter feature) HOT 3
- Missing space at damage type description of magical Items HOT 1
- Investigate why Chaos Bolt spell includes damage with no defined type HOT 4
- D20 at Advantage Summing instead of Choosing a Value HOT 2
- Cleric: Death Domain: Circle of Mortality is labeled HOT 1
- Bladesong concentration-check improvement suggestion
- Blood Hunter's crimson rite, a potential improvement, clarifying damage types. HOT 1
- Classes page handler should limit its roll button check to the contents and ignore comments section HOT 2
- Hunter's Mark MIA? Sheet scan incomplete? Or just user over-expectations? HOT 2
- [Proposal] Add Roll History Button for Individual Character Sheets HOT 5
- Third whisper setting, where d20 roll is public, but the rest is only to the GM. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beyond20.