isLegacyProjectConfig has logical error.

[charleslai2000]

isLegacyProjectConfig has logical error.

[dimaMachina]

Where did you see it?

graphql-config/src/helpers/utils.ts

Lines 11 to 16 in 423de0e

	export function isLegacyProjectConfig(config: IGraphQLConfig): config is IGraphQLProjectLegacy {
	return (
	(config as IGraphQLProjectLegacy).schemaPath !== undefined ||
	(config as IGraphQLProjectLegacy).includes !== undefined ||
	(config as IGraphQLProjectLegacy).excludes !== undefined
	);

[charleslai2000]

The code piece is in "src/project-config.ts". The logic flaw is when some config file has provided includes or exludes ( in my case, @graphql-eslint will refuse lint file if don't support includes), isLegacyProjectConfig will treat it as legacy. But includes and excludes also are read when not in legacy mode.

So, if you provide a config with schema, includes field, it will always to treat as legacy mode, and schema filed will be undefined. I spent 1d to find this problem when config my graphql LSP and eslint plugin.

I don't kown why this condition is needed? Can you judge it as simple as " if (config.schemaPath !== undefined) "?

[dimaMachina]

So the problem is not with graphql-config but with graphql-eslint?