inconsistent results in case of LEFT OUTER JOIN, GROUP BY and HAVING

[x2es]

inconsistent results in case of LEFT OUTER JOIN, GROUP BY and HAVING

[x2es]

Some related issues:

#936
#1031

Maybe needed some warn/error similar to #1054

[arianf]

I noticed something similar to this.

When I had duplicate results within my query, the total_count would calculation would early exit.

This seemed to be because of this:

kaminari/kaminari-activerecord/lib/kaminari/activerecord/active_record_relation_methods.rb

Lines 24 to 25 in 325fc07

	# Total count is calculable at the last page
	return @total_count = offset_value + @records.length if @records.any? && (@records.length < limit_value)

Which would early exit if @records.length < limit_value. It seemed like for example if you set your limit to 25 per page, that if your query has duplicates, those will get removed somewhere upstream, and it would result in 21 records for the first page. Then because that is less than the limit_value, Kaminari thinks it's on the last page, and doesn't do a correct total_count.

@yuki24 @tumayun I think was was introduced by: #932