Giter Site home page Giter Site logo

Comments (2)

kamo-naoyuki avatar kamo-naoyuki commented on June 6, 2024

Thank you for using my modules and reporting issue, but I'm not sure your case.
The behaviour of batch_first is very simple and I think there are no bugs.

def forward(input, weight, hidden, batch_sizes):
if batch_first and batch_sizes is None:
input = input.transpose(0, 1)
nexth, output = func(input, hidden, weight, batch_sizes)
if batch_first and batch_sizes is None:
output = output.transpose(0, 1)

If you are using PackedSequence, this option should be ignored.

from pytorch_convolutional_rnn.

RiqiangGao avatar RiqiangGao commented on June 6, 2024

Thank you for using my modules and reporting issue, but I'm not sure your case.
The behaviour of batch_first is very simple and I think there are no bugs.

pytorch_convolutional_rnn/convolutional_rnn/functional.py

Lines 307 to 314 in 094b3bd

def forward(input, weight, hidden, batch_sizes):
if batch_first and batch_sizes is None:
input = input.transpose(0, 1)

 nexth, output = func(input, hidden, weight, batch_sizes) 

 if batch_first and batch_sizes is None: 
     output = output.transpose(0, 1) 

If you are using PackedSequence, this option should be ignored.

Thanks a lot again. I will take a further look.

BTW, I have motivated by your RNN cell functions before and they help my project. And I plan to learn all your functions about RNN. Thanks for sharing.

from pytorch_convolutional_rnn.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.