Moving tasks by drag'n'drop does not work

[kanboard]

Moving tasks by drag'n'drop does not work

[fguillot]

I just tried with Firefox 27, and it seems to work for me.

Do you have any error messages or php errors?

Can you try with the online demo to see if the problem come from your installation or something else, http://demo.kanboard.net/ and demo/demo123

Thanks.

[toomyem]

I've made some investigation and it looks like there is a mistake in isUserAllowed function. I made a pull request #42 to correct it. I'm not very familiar with the code yet, so maybe it can be done in some better way. Now I'm just suggesting a possible solution.

I noticed that the problem with DnD occurs when I'm logged as user with admin privileges and try to move task in project which has some users in acl. It happened that my current user were not on this acl list. That is why DnD were not performed.

But in this case there shall be some notification to the user that he is not allowed to move the task and task shall be moved back on the board to the original column. This is not covered by my pull request.

I see you have tests related to users in project. But you are testing the opposite case. Is this correct?

$this->assertFalse($p->isUserAllowed(1, 1));

User 1 is admin and was revoked two lines earlier. But it is admin, so even so he shall be allowed.

[fguillot]

Yes you are right, so I merged your pull-request. I improved my unit test but it's not entirely done, I don't cover all cases. I also need to improve the DnD...

I close this issue because you finally found the problem.