Giter Site home page Giter Site logo

Comments (6)

Firstyear avatar Firstyear commented on June 11, 2024 1

@0xC0ncord We're going to make this a bool on public clients that allows a localhost redirect as an option, port isn't going to be checked. The reason is that we enforce PKCE which protects the exchange.

from kanidm.

Firstyear avatar Firstyear commented on June 11, 2024

Given it's redir to localhost, this implies it also has to be a public client does it not? If that's the case, we could make it so public clients have an "allow redirects to localhost" bool where we can special case and check this. Public clients enforce PKCE is required too btw.

from kanidm.

yaleman avatar yaleman commented on June 11, 2024

Yep, I think that's the case - but we should require registration of the URL 'cause I don't want arbitrary localhost:* to be allowed

from kanidm.

Firstyear avatar Firstyear commented on June 11, 2024

The problem is applications may dynamically select the localhost port - this is also what PKCE exists to protect against if the token is sent to the wrong localhost application.

from kanidm.

yaleman avatar yaleman commented on June 11, 2024

Bleeeeehhhh those applications need to get in the bin 😄 Have we seen any examples of them yet? Vault and netbird use static ports.

from kanidm.

0xC0ncord avatar 0xC0ncord commented on June 11, 2024

Have we seen any examples of them yet? Vault and netbird use static ports.

kubelogin's port is configurable (by manually specifying the listen address) but not dynamic.

from kanidm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.