Comments (2)
STATUS: APPROVED!!! π π π πΎ πΎ πΎ
Hi Team,
Good job !!!
To Highlight! π π’
βοΈ Good job with issue summary
Your project is complete! Great work on making the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it
Congratulations! π π π πΎ πΎ πΎ
Optional suggestions
Check the comments under the review.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
N/A
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack using this handle @Mihndim.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from recipe-app.
Hi @KanzaTahreem & @rbreva,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Descriptive issue βοΈ
- Setup correctly the Kanban board βοΈ
Required Changes β»οΈ
- As required in the project all the cards should have a description but your #10 and #11 donβt have a description, kindly add a description to the two issues π π
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
from recipe-app.
Related Issues (13)
- [0.25pt] Initialize rails application and database
- [0.5pt] Set up Devise for authentication.
- [3pt] Create a Food list
- [4pt] Create Recipes list
- [2pt] Create Public recipe list
- [3pt] Create Recipe details page
- [3pt] General shopping list view
- [1pt] Make sure there are no N+1 queries
- [1pt] Create a navigation menu
- [5pt] Set up RSpec and Capybara testing libraries (member 1)
- [5pt] Set up RSpec and Capybara testing libraries (member 2)
- [2pt] Design the application
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recipe-app.