Giter Site home page Giter Site logo

The password inserted into the database when adding a user is a hash value, but it is plaintext when updating a user. about cookiecutter-flask-restful HOT 2 CLOSED

karec avatar karec commented on May 16, 2024
The password inserted into the database when adding a user is a hash value, but it is plaintext when updating a user.

from cookiecutter-flask-restful.

Comments (2)

karec avatar karec commented on May 16, 2024

Hello @LANVNAL and thanks for reporting this.

This is indeed a bug and you pin-pointed precisely the issue: __init__ is never called by marshmallow-sqlalchemy when updating and I've hadn't added necessary logic to handle that case.

To fix this and avoid future issues with this, I've put the password hashing logic in an hybrid_property with an associated setter instead of putting the logic inside the endpoint itself.

I've also added a check inside the test_put_user

Related commit

from cookiecutter-flask-restful.

karec avatar karec commented on May 16, 2024

Issue fixed on master, I'm closing this issue. Thanks again for reporting !

from cookiecutter-flask-restful.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.