Comments (3)
What is the maximum allowed line length in your project?
I need that for configuring my linters. Some of your line longer than 80 chars (linter default).
from orgparse.
Hey, I'm very relaxed about all this. There is just one branch in the repo, so obviously it's just created against master
:)
I don't care about branch naming. No code guidelines within reason -- the only thing I care about is tests and perhaps type annotations. As long as you don't reformat the whole project in a different code style I don't care about style, line length etc.
Usually when I want to find out how to run tests etc for a project, I look at the CI configuration, e.g. https://github.com/karlicoss/orgparse/blob/master/.github/workflows/main.yml
I find it is more self explanatory, and will always be up to date unlike maintaining CONTRIBUTE.md. You look like an experienced developer judging by your github so I'm sure you could figure that out too :)
from orgparse.
Dear karlicoss ,
thanks for your feedback.
Hey, I'm very relaxed about all this.
It is up to you because you are the maintainer. But IMHO this will drive some contributors away.
Usually when I want to find out how to run tests etc for a project, I look at the CI configuration, e.g. > https://github.com/karlicoss/orgparse/blob/master/.github/workflows/main.yml I find it is more self explanatory, and will always be up to date unlike maintaining CONTRIBUTE.md.
The github ci yaml file belongs to a proprietary system and is not self explanatory. And if it was it doesn't answer all questions which answers I would write into a CONTRIBUTE.md or a Contribute section of a README.md.
You look like an experienced developer judging by your github so I'm sure you could figure that out too :)
What you name "figuring out" is wasting time for each potential contributor to your project. The maintainer should figure it out, document it somewhere (e.g. CONTRIBUTE.md) and save a lot of time for other people and their resources so they can invest it in real problems and issues related to orgparse
.
Even that you are "relaxed" about all this could be written down somewhere. In that case new contributors do know what do deal with.
from orgparse.
Related Issues (20)
- Date parsing with timezone information HOT 2
- speedup parsing
- Invalid syntax when trying to use the library HOT 5
- orgparse.load() is broken for file-like objects HOT 3
- support names on tables HOT 1
- Support more Effort format in Properties HOT 2
- Repeated_tasks and logbook parsing HOT 4
- Minor difference in date objects parsed
- Support properties in OrgRootNode HOT 2
- Question: Why is `_special_comments['TITLE']` a list? HOT 1
- parsing of multiline properties HOT 1
- QUESTION: Reason about using `codecs.open()` HOT 2
- Move `tests` outside the package folder HOT 4
- Providing OrgEnv to load() with pathlib.Path errors HOT 1
- Logbook drawer tags are not removed from body text HOT 1
- Non-existant date errors without context HOT 5
- Extracting line numbers from org nodes? HOT 1
- How to access comments and properties in clocks (Loogbook entry)
- __version__ missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orgparse.