Giter Site home page Giter Site logo

Comments (3)

buhtz avatar buhtz commented on September 27, 2024

What is the maximum allowed line length in your project?
I need that for configuring my linters. Some of your line longer than 80 chars (linter default).

from orgparse.

karlicoss avatar karlicoss commented on September 27, 2024

Hey, I'm very relaxed about all this. There is just one branch in the repo, so obviously it's just created against master :)
I don't care about branch naming. No code guidelines within reason -- the only thing I care about is tests and perhaps type annotations. As long as you don't reformat the whole project in a different code style I don't care about style, line length etc.
Usually when I want to find out how to run tests etc for a project, I look at the CI configuration, e.g. https://github.com/karlicoss/orgparse/blob/master/.github/workflows/main.yml
I find it is more self explanatory, and will always be up to date unlike maintaining CONTRIBUTE.md. You look like an experienced developer judging by your github so I'm sure you could figure that out too :)

from orgparse.

buhtz avatar buhtz commented on September 27, 2024

Dear karlicoss ,

thanks for your feedback.

Hey, I'm very relaxed about all this.

It is up to you because you are the maintainer. But IMHO this will drive some contributors away.

Usually when I want to find out how to run tests etc for a project, I look at the CI configuration, e.g. > https://github.com/karlicoss/orgparse/blob/master/.github/workflows/main.yml I find it is more self explanatory, and will always be up to date unlike maintaining CONTRIBUTE.md.

The github ci yaml file belongs to a proprietary system and is not self explanatory. And if it was it doesn't answer all questions which answers I would write into a CONTRIBUTE.md or a Contribute section of a README.md.

You look like an experienced developer judging by your github so I'm sure you could figure that out too :)

What you name "figuring out" is wasting time for each potential contributor to your project. The maintainer should figure it out, document it somewhere (e.g. CONTRIBUTE.md) and save a lot of time for other people and their resources so they can invest it in real problems and issues related to orgparse.
Even that you are "relaxed" about all this could be written down somewhere. In that case new contributors do know what do deal with.

from orgparse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.