Comments (10)
We use a custom iniparser (ndevilla/iniparser). I don't think it's the one available in Gentoo and it works, so replacing it isn't a good idea.
from cava.
I don't know much about iniparsers, but if there is a system-wide iniparser with packages for all mayor distros (libconfig?), then maybe we should check it out. If not, @CelestialWalrus solution is probably best for now .
from cava.
@CelestialWalrus
We use a custom iniparser (ndevilla/iniparser). I don't think it's the one available in Gentoo
No, that's the same iniparser packaged in Gentoo and Arch. The upstream URL link on Arch's iniparser package and the Homepage link on Gentoo's iniparser package both point to the project's homepage, which links to the github page.
it works, so replacing it isn't a good idea
For some actual counter-points, see the static linux FAQ.
I'm in favour, mainly because this allows improvements to happen to the libraries we rely on, without us having to do anything. Iniparser is a really common library, so almost all distros have it packaged (Ubuntu, CRUX, CentOS, Fedora…). For packagers, having the option to compile against a system library sounds like a good thing.
from cava.
We use a custom iniparser (ndevilla/iniparser).
It's the same author, it's not a fork. Looking at http://ndevilla.free.fr/iniparser/index.html you can see
git clone http://github.com/ndevilla/iniparser.git
up there, pointing to the very same Git repository.
I don't think it's the one available in Gentoo and it works, so replacing it isn't a good idea.
It soon will be, see https://bugs.gentoo.org/show_bug.cgi?id=556774 and ndevilla/iniparser#62.
from cava.
valid points.
as I said earlier, if there is a system iniparser available for all major distros we should definitely use it. And if you want to create the patch @hartwork that would be awesome as I am striped from time at the moment. But I can't seem to find iniParser for Ubuntu/debian, am I missing something?
from cava.
But I can't seem to find iniParser for Ubuntu/debian, am I missing something?
The link by @anko for ubuntu is an unofficial repository. Officially, Debian and Ubuntu do not have a package for iniparser, afaik. There was a "intent to package" ticket (ITP for short) in Debian but it was closed, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582657#51.
from cava.
@hartwork ok, how about using libconfig? To me it looks like it does the same as ini parser and I think there is also available packages for all mayor distros. I'll pull your request for now, but I really think we should make things as distro independent as possible.
@CelestialWalrus what do you think? You wrote the original config file stuff for iniparser, do you think it could be "ported" to use libconfig instead? Its API looks pretty straight forward.
from cava.
@karlstav I'm busy with projects ATM, so I won't be able to port it now.
from cava.
@hartwork ok, how about using libconfig? To me it looks like it does the same as ini parser and I think there is also available packages for all mayor distros. I'll pull your request for now, but I really think we should make things as distro independent as possible.
No objections. If you want to go that road, I would recommend to code against both libconfig 1.4.9 and 1.5 (if their interface differs) so that both users of a stable and bleeding-edge distro (or release of a distro) have what you need. For example on Debian:
oldstable wheezy 1.4.8
stable jessie 1.4.9
testing stretch 1.4.9
unstable sid 1.5
from cava.
this is implemented in 0.4.0
from cava.
Related Issues (20)
- Config ignored on Windows 11 HOT 2
- Is it possible to remove the bar heads from idle Cava? HOT 2
- Release the app on Fdroid HOT 4
- Two squares (not umlaut) on top of each bar if starting over ssh HOT 4
- Very high sensivity HOT 2
- Segmentation fault HOT 2
- Keyboard controls are ignored when pausing PipeWire input HOT 6
- Erratic when waveform activated HOT 2
- Cava ignores the config file HOT 2
- Fails to build with iniparser 4.2 HOT 3
- Cava terminated with SIGSEGV at startup HOT 28
- missing <stdlib.h> in config.c
- Is it possible to integrate into a console-based music player? HOT 1
- Error: failure in opening stream (Invalid number of channels) HOT 1
- error while loading shared libraries: libiniparser.so HOT 14
- Linking fails on 10.6: `Undefined symbols: _glGenVertexArrays, _glReleaseShaderCompiler, _glBindVertexArray` HOT 5
- Cava causing crashes of pipewire HOT 1
- Gradient depends on the window size HOT 5
- Waves don't work properly in raw mode. HOT 18
- Error while loading shared libraries...
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cava.