Comments (4)
Hey,
happy to hear you are considering using karma to test mocha :)
To be honest I'm not a big fan of peerDependencies in general, especially in npm@2. We had a lot if issues with them in development as we use it for specifying the karma version. With npm@3 they are much better I think.
As for what to do now, I would like to keep moch as a peerDependency, mostly for consistency woth other karma plugins and hope npm@3 gets adopted quickly.
For using it in mocha I would suggest having an afterInstall step that deleted node_modules/mocha and symlinks it to ../ so that karma-mocha uses the actual moch version. We do the same thing at the moment on the karma main repo to work around the auto install of peerDependencies.
Would that work for you?
We should change that *
dependency to be a bit more restrictive to avoid issues with api changes you are right there.
from karma-mocha.
Currently npm v3 throws a max call stack exception if a package is symlinked to itself. I'm not sure if that's a real bug; at the very least they should have a friendlier error message. I'll inquire over there.
from karma-mocha.
With npm v3, an unmet peer dep will result in a warning only.
I think warning better than README.md. Users don't read README. For testing mocha you can manually link mocha as node_module in mocha directory.
Thanks
from karma-mocha.
Already fixed in this PR
from karma-mocha.
Related Issues (20)
- Passed --grep option persists across test runs HOT 1
- npm test - Uncaught ReferenceError: describe is not defined HOT 3
- No provider for "framework:mocha"! (Resolving: framework:mocha) HOT 11
- karma tests slowed down with mocha 4
- Applying polyfill before loading mocha HOT 6
- Can I keep tests in a normal mocha index.html? HOT 3
- Delay __karma__.start() until es6 test modules have been loaded HOT 1
- maintainers and status of project HOT 4
- Usage of exact version of minimist HOT 4
- When will commit: 36404cf36aa5150f839c98d10baa8c642faad098 will be relaesed? HOT 1
- Uncaught exception: emitting a 'test end' event for a hook HOT 1
- Redundant Mocha Reporter Node <div id="mocha"></div> HOT 1
- Uncaught exceptions in between Mocha tests are not reported HOT 2
- Support for mocha root hooks
- adapter.js swallows failures that occur after test complete
- Unit tests are missing when `script type="module"` takes >= 3ms before `describe` HOT 1
- Reestablish CI/CD with GitHub Actions
- The dependency minimist "^1.2.3" is declared as vulnerable need to update to 1.2.6 or more HOT 1
- Status of this project? HOT 4
- Analysis: 76% of dependency updates in this repository can be merged.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from karma-mocha.