Giter Site home page Giter Site logo

Comments (5)

MaxPowerWasTaken avatar MaxPowerWasTaken commented on May 8, 2024 1

Hi Andrej,

I ran into this issue as well as I am using multi-page pdfs, so I've addressed this in my local branch.

If you would be receptive to a PR with one change, that would just save images instead as:

  • [pdf_name_page_n.jpg] for n in 1..page-length (if page-length > 1), or
  • [pdf_name.jpg (current behavior)] if page-length==1

...I'd be happy to submit one. Obviously your call though. I'm a big fan of this repo and find your code very easy to work with, so I definitely appreciate your open-sourcing this!

from sparrow.

abaranovskis-redsamurai avatar abaranovskis-redsamurai commented on May 8, 2024 1

Hey Max, sure, please submit the change, I will merge it. Thanks a lot :)

from sparrow.

MaxPowerWasTaken avatar MaxPowerWasTaken commented on May 8, 2024 1

PR submitted here: #18.

Sorry to take a while to get this submitted after proposing it last week.

from sparrow.

abaranovskis-redsamurai avatar abaranovskis-redsamurai commented on May 8, 2024 1

Thanks, the changes merged.

from sparrow.

abaranovskis-redsamurai avatar abaranovskis-redsamurai commented on May 8, 2024

Thanks, @rajans, good catch. At the moment, I test code only with single-page docs, I will keep it as is for now. I added a comment in the code, so as not to forget it in the future.

from sparrow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.