Giter Site home page Giter Site logo

Comments (9)

kawamataryo avatar kawamataryo commented on July 18, 2024 4

@Gitoffthelawn
Hi 👋
I made a new version.
In this version, the DOM is not injected from content script, and the form is displayed in a popup.
"Access your data for all websites" is no longer required.

#9

The release to the store is still some way off, but I think this version will resolve this issue.

from chikamichi.

kawamataryo avatar kawamataryo commented on July 18, 2024 2

I'll consider fix it so that it shows up in a popup.

from chikamichi.

kawamataryo avatar kawamataryo commented on July 18, 2024 1

Thanks for the question!
This setting is the permissions required for the chikamichi's modal to open on all web sites.
If this is not specified, the modal will not open, as it will block the loading of content_script.js.

For a more detailed, please read to the following site

https://support.mozilla.org/en-US/questions/1299613

from chikamichi.

kawamataryo avatar kawamataryo commented on July 18, 2024 1

Ah.
I didn't image the popup well.
When you say "display in popup", are you thinking of something like black-menu?

https://apps.jeurissen.co/black-menu-for-google

I think it's worth a try.

from chikamichi.

Gitoffthelawn avatar Gitoffthelawn commented on July 18, 2024 1

Ah. I didn't image the popup well. When you say "display in popup", are you thinking of something like black-menu?

https://apps.jeurissen.co/black-menu-for-google

I think it's worth a try.

I have to experiment with that extension to see if that's similar to what I meant. Either way, my primary interest is in having the most functionality (and keeping the UX excellent) without needing the "Access your data for all websites" permission.

Also, DOM injections can get messy, cause issues, and be hard to maintain, so when possible, I think it's best to avoid that technique. That said, sometimes it is the only way to get the desired functionality.

from chikamichi.

Gitoffthelawn avatar Gitoffthelawn commented on July 18, 2024 1

Wow, that's exciting! ありがとう!

from chikamichi.

Gitoffthelawn avatar Gitoffthelawn commented on July 18, 2024

You're welcome and thank you for the answer.

Makes sense.

Thinking aloud here...

Would it be possible/reasonable to use a toolbar popup instead of an overlay modal injected into the DOM? (I haven't reviewed the code yet, but I'm guessing that's what you are doing.)

I'm trying to brainstorm a way to have almost the same functionality without needing that big permission.

from chikamichi.

kawamataryo avatar kawamataryo commented on July 18, 2024

Would it be possible/reasonable to use a toolbar popup instead of an overlay modal injected into the DOM? (I haven't reviewed the code yet, but I'm guessing that's what you are doing.)

I think it is possible to show history and bookmark information in popup.
However, I don't know if it is possible to ensure the same operability as now. I chose to use modal because I wanted to be able to control everything with keyboard shortcuts.

from chikamichi.

Gitoffthelawn avatar Gitoffthelawn commented on July 18, 2024

Hmmm... still thinking aloud...

What about displaying content in the sidebar? I think that allows keyboard shortcuts.

from chikamichi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.