Comments (6)
Hello, @tbl0605
Thanks for the reporting and such a deep dig into the bug :)
from vue-simple-suggest.
@kaskar2008, would it be possible to make a new release now that this patch is merged?
Thank you for you great work :)
from vue-simple-suggest.
I forgot to mention that I can reproduce this bug (at least) on latest versions of Chrome and Firefox :)
from vue-simple-suggest.
The issue disappears with my patch (I cannot reproduce the bug anymore).
But you should consider it as a partial fix or workaround, because there is a real deeper problem in your code (I haven't tracked it down), the value of "isPlainSuggestion" seems (sometimes) not to be in sync (or updated soon enough) to reflect latest values retrieved from method getSuggestions().
So my patch will "hide" the real problem but not completly fix it.
For example, before my patch, you could have :
- "isPlainSuggestion" is set to true because getSuggestions() returned an empty array of values (setting it to true was buggy, my patch fixes that)
- getSuggestions() is called again and returns a non-empty array of values BUT those list of suggestions is (wrongly) drawn with "isPlainSuggestion" still set to true
Hope I'm clear enough :)
from vue-simple-suggest.
My guess for the real problem is that multiple calls to "await this.list(value))" can be done in a very short time and those promises can resolve in any order when the server api is a bit laggy.
Probably getSuggestions() should return an object containing "isPlainSuggestion" and the list of suggestions, so that both would be synchronized and be updated at same time (and neither too early nor too late).
from vue-simple-suggest.
Hopefully last comment: I updated my patch so it can be taken as-is, without doing further code changes afterwards, even if I think that "isPlainSuggestion" should be updated outside of getSuggestions() at same time than this.$set(this, 'suggestions', newList)
from vue-simple-suggest.
Related Issues (20)
- value-attribute doesn't return id HOT 1
- Is there a way to accept values that are not from the list? HOT 2
- autocomplete not working on chrome, probably to browser autocomplition functionality HOT 18
- [Vue warn]: Error in callback for watcher "value": "TypeError: Cannot read property 'length' of null" HOT 1
- operate as a standard `select` HOT 1
- In "select" mode, how do I prevent an extra query from being executed when I select an item? HOT 5
- TypeError: this.inputElement is null HOT 1
- Stop hideList and select multiple HOT 1
- Vue 3 support HOT 8
- Unable to select a menu item when you have to scroll down (big issue) HOT 4
- "TypeError: this.inputElement is null" still not fully fixed (new error: "No input element found") HOT 1
- [Feature] add additional text for suggest. HOT 1
- hide scrollbar HOT 1
- @click listener within misc-item slot HOT 2
- Example with :filter HOT 1
- Test the component using `vue-test-utils`
- List method always gets the previous model value HOT 1
- OnLoad filled object is set to null
- Use Ref focus then it can not suggest
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vue-simple-suggest.