Underline and Title are not vertically aligned

[longunidev]

Underline and Title are not vertically aligned

[kazuhiro4949]

@finlayjn thanks for your help. I fixed the issue.

[kazuhiro4949]

@longunidev I'm sorry for the late reply. Could you show me the code snippet?

[finlayjn]

Just ran into the same issue. My code is very closely based on the Reloadable example, but I can send some if it helps. For me, the issue seems to arise from adding and removing view controllers from the data source. I implemented the following workarounds:

Reset the underline when updating the data source:

var dataSource = [(menu: String, content: UIViewController)]() {
        didSet {
            menuViewController?.reloadData()
            contentViewController?.reloadData()
            menuViewController?.focusView.subviews.forEach {$0.removeFromSuperview()}
            menuViewController?.registerFocusView(view: UnderlineFocusView())
        }
    }

Scrolling away before removing a page also seems to help:

let closingIndex = menuViewController?.currentFocusedIndex
// Scroll to next page to the left if closing the rightmost page
if closingIndex == dataSource.count - 1 && dataSource.count > 1 {
    menuViewController?.scroll(index: closingIndex! - 1, animated: true)
    contentViewController?.scroll(to: closingIndex! - 1, animated: true)
// Otherwise, scroll to next page to the right
} else if dataSource.count > 1 {
    menuViewController?.scroll(index: closingIndex! + 1, animated: true)
    contentViewController?.scroll(to: closingIndex! + 1, animated: true)
    menuViewController?.scroll(index: closingIndex!, animated: false)
    contentViewController?.scroll(to: closingIndex!, animated: false)
}
dataSource.remove(at: (closingIndex)!)

[kazuhiro4949]

@finlayjn Thanks. I'm going to try to reproduce the issue.

[kazuhiro4949]

@finlayjn I couldn't reproduce the issue with MenuReloadableViewController. Could you give me any additional information?

[finlayjn]

Sure. Like I said I think it's an issue with updating the data source. More specifically, it seems to occur when the data source is empty and an item is added. Here's the changes I made to reproduce the issue in the MenuReloadableViewController example in the sample project:

Change "menus" constant to a variable and leave it empty to begin.

var menus: [String] = []

Add this line to the reloadButtonDidTap action before updating dataSource.

self.menus.append("Menu")

Run the app and press the Reload button. The first menu item that appears will not be aligned with its underline.