Comments (4)
unsafe
is not always followed by brackets. Example from the nomicon:
unsafe impl<T: Send> Send for Unique<T> {}
from cargo-count.
Yep, the actual regex doesn't assume that it will be. In fact, the goal is mark and count the entire function as unsafe when used to mark a function and not a block.
I have a stash locally that I'm working on with a far more accurate regex and counting function, but it isn't 100% correct....so if you have a solution I'm all ears ;)
from cargo-count.
Ah sorry, from the issue I assumed that it only matched blocks. My bad :)
If I had no exams I would have tried to help more but until end august I am
a bit in a rush ;)
On Aug 22, 2015 6:52 AM, "Kevin K." [email protected] wrote:
Yep, the actual regex doesn't assume that it will be. In fact, the goal is
mark and count the entire function as unsafe when used to mark a function
and not a block.I have a stash locally that I'm working on with a far more accurate regex
and counting function, but it isn't 100% correct....so if you have a
solution I'm all ears ;)—
Reply to this email directly or view it on GitHub
#5 (comment).
from cargo-count.
No worries! :)
After going through my latest Rust checkout (which I'll use as my "official" guide for correctness on this issue) with some crazy grep
ping I've found 2861 lines that I believe are valid unsafe
lines. What I don't know is how many of those lines are inside of /* block comments */
which will get ruled out by the counting function....but let's just say 2861 for the sake of argument.
Since a large majority of those lines are actually starting unsafe blocks, cargo-count
should probably have a significant number above that.
from cargo-count.
Related Issues (18)
- C and C Headers have some unsafe code HOT 8
- cpp is not the only extension for C++ HOT 7
- Block comment bug HOT 1
- Unused import std::io::Write HOT 1
- Everything excluded when using exclude-all-then-add-some .gitignore HOT 9
- error: stream did not contain valid UTF-8 HOT 1
- cargo-count doesn't find any code HOT 6
- Incorrect number of "unsafe" instances reported
- Add more languages HOT 1
- unable to install HOT 4
- Numerous warnings when building cargo-count
- Looking for maintainers?
- Add support of GLSL
- cargo count dies if there are broken symlinks in tree HOT 2
- cago count will fail if a symlink points to a parent directory HOT 2
- cargo count counts rust source files in the target/ directory HOT 2
- Add option to use .gitignore as baseline for --exclude
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cargo-count.