Giter Site home page Giter Site logo

Comments (5)

kburtch avatar kburtch commented on August 30, 2024

Yes, there is a bug in the current logic. I turning off PostgreSQL worked but turning off MySQL did not. "-z" is working correctly as far as I know...I don't use it to check for 1 or 0. I will check into this more in a few days when I have more time.

from sparforte.

qunying avatar qunying commented on August 30, 2024

You current testing actually make HAS_MYSQL and HAS_POSTGRES have the right value when at the stage of configuring APQ.

At your checking in line 928 of configure, only when NO_MYSQL is not set will it try to detect HAS_MYSQL, otherwise it is always empty regardless the system has it or not. The same goes to PosgreSQL, so it is more logical to to use HAS_MYSQL or HAS_POSTGRES in the APQ configure. The logic is more clear IMHO.

from sparforte.

kburtch avatar kburtch commented on August 30, 2024

Checked and merged. Replaced some ! -z with -n. Added comments.

from sparforte.

kburtch avatar kburtch commented on August 30, 2024

I've added a new set of tests to verify the configure flags work correctly for the databases. Let me know if this issue can be closed or if more work is needed.

from sparforte.

kburtch avatar kburtch commented on August 30, 2024

closing issue after 10 days. no response from reporter.

from sparforte.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.