Add Python 3.6 support

[leggewie]

Add Python 3.6 support

[leggewie]

Related to this, version 3.0.0 is still available for those on python versions lower than 3.7. I would think, this might not be intended.

[kdeldycke]

While mail-deduplicate version 3.0.0 is working on paper with python versions lower than 3.7, it is so full of issues that I do not recommend using it.

I aggressively deprecated Python 3.6 and required Python 3.7 while I was repackaging the whole project in commit: 4908e33 for the v4.0.0 release.

There might be not a lot of work to do to have Python 3.6 support. I can help you polish a pull request to had 3.6 support. Start by adding 3.6 in the CI test code and package requirements. Did you tried to run the code under Python 3.6 in your environment?

[leggewie]

I certainly agree in principle with your push to move on.

All I did locally so far was to lower the requirements for python from ^3.7 to ^3.6 in pyproject.toml, simply to get things running for me on bionic. Afterwards, I produced the wheel with poetry and installed via pip. All issues I've run into seem to be unspecific to python 3.6 and were reported in this tracker.

I shall open a new branch at https://github.com/leggewie/mail-deduplicate/commits/bionic

[kdeldycke]

Thanks @leggewie for trying that out! Your bionic branch looks good to me. Feel free to propose it as a PR. We'll see how the test suite react to that.

[leggewie]

Before closing this ticket, should version 3.0.0 be removed or remain on pypi.org, possibly for users of python2?

[kdeldycke]

The general rule is to not purge any of the the history of released packages on PyPi. If a previous release is bad or botched, just re-release a new revision.

The only case in which it make worth the effort removing old packages is if it got malware or private data in it! ;)

[leggewie]

I see. Makes sense in general. Users of python 3.6 and below get the very outdated (and I suspect completely unsupported) software that way which isn't ideal, though.

[kdeldycke]

I see. Makes sense in general. Users of python 3.6 and below get the very outdated (and I suspect completely unsupported) software that way which isn't ideal, though.

Yes. Until we release a brand new version that supports 3.6 thanks to your work at #169 ! 😃

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.