Giter Site home page Giter Site logo

Comments (3)

gplwhite avatar gplwhite commented on May 23, 2024

I think there is a second issue with the filtering of the DefactoStandardResolutions.

The following lines don't seem to take operator precedence into account correctly. The modulo division has a higher order of precedence than the subtraction meaning it will happen before the subtraction. I think there should be parenthesis around the subtraction to ensure it occurs before the modulo division.

(r.Width - stepwise.min_width % stepwise.step_width) == 0 &&

and

(r.Height - stepwise.min_height % stepwise.step_height) == 0).

Currently I believe this will result in no characteristics being returned for devices that report a Stepwise frame size capability

(specifically this issue along with #127 seems to be stopping my Raspberry PI onboard camera from being enumerated successfully)

from flashcap.

kekyo avatar kekyo commented on May 23, 2024

@gplwhite I will review it in a couple of days, just wait and see.

from flashcap.

kekyo avatar kekyo commented on May 23, 2024

Merged, thanks!

from flashcap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.