Comments (9)
@zw963 thanks for the report, what's your Kemal version? I remember fixing this behavior, this is the previous issue #630
from kemal.
Current, i use version: 1.1.2, but, i can reproduce this on the master, i can reproduce it on d53d253 too
╰─ $ shards list
Shards installed:
* kemal (1.1.2 at d53d253)
* radix (0.4.1)
* exception_page (0.2.2)
* backtracer (1.2.1)
* avram (0.23.0)
* lucky_task (0.1.1)
* pg (0.26.0)
* db (0.11.0)
* habitat (0.4.7)
* wordsmith (0.3.0)
* dexter (0.3.4)
* shell-table (0.9.3)
* pulsar (0.2.3)
* lucky_cache (0.1.1)
* splay_tree_map (0.2.2)
* habitat (0.4.7)
* cadmium_transliterator (0.1.0 at 46c4c14)
from kemal.
I can confirm, my installed kemal version include those changes in #630
from kemal.
Hi, if need more context for this issue? if you want, please tell me, i will add it here.
from kemal.
@zw963 I tried to reproduce the issue and could not reproduce. Here's the repo that I used to reproduce https://github.com/sdogruyol/kemal-layout-bug, could you please clone and run this on your local and see if it works on your side too?
from kemal.
@zw963 I tried to reproduce the issue and could not reproduce. Here's the repo that I used to reproduce https://github.com/sdogruyol/kemal-layout-bug, could you please clone and run this on your local and see if it works on your side too?
Yes, i can, please check following screenshot.
BTW: i consider there exists some syntax error on view, i fixed, please check following diff.
╰─ $ git diff
diff --git a/src/views/home.ecr b/src/views/home.ecr
index fb85025..df95b8a 100644
--- a/src/views/home.ecr
+++ b/src/views/home.ecr
@@ -1,6 +1,6 @@
<h1> Title 1</h1>
<h2> Title 2</h2>
-<% content_for "title" %>
+<% content_for "title" do %>
<title>Inner Title</title>
-<% %>
\ No newline at end of file
+<% end %>
Above diff i create a PR for it. sdogruyol/kemal-layout-bug#1
from kemal.
Thank you @zw963, I can reproduce it now 👍 I'll look into what's going on
from kemal.
@zw963 just merged #639 into master, could you please try with that. It should work now 👍
from kemal.
@sdogruyol , it works! thank you.
from kemal.
Related Issues (20)
- Slang doesn't render anymore HOT 10
- [Question] What is the correct way to share a object(e.g. current_user) across kemal session HOT 3
- before_all can not intercept http processing use env.redirect "new_path" HOT 13
- Internal API broken in Crystal nightly
- Logs are messed up in multithreaded mode HOT 2
- build failed with latest crystal HOT 5
- Error: undefined method 'modification_time' for Kemal::StaticFileHandler (Crystal 1.6.0) HOT 2
- Compilation issue with crystal 1.6 HOT 4
- Problem serving local files HOT 5
- MacOs Ci is broken HOT 5
- A simple hello world kemal app run on windows failed. (but compilation on github action successful) HOT 1
- StaticFileHandler doesn't work on Windows HOT 1
- Kemal won't clean up broken file uploads HOT 2
- before_all handler isn't called for error routes HOT 4
- Adding Handlers HOT 2
- bug:Unhandled exception: Not Implemented: Crystal::System::Signal.trap (NotImplementedError) from D:\Dev\Crystal\src\crystal\system\win32\signal.cr:5 in 'trap' HOT 2
- Date Header Missing from Kemal HOT 2
- a list of all configured routes? HOT 1
- Error page doesn't (re)set content_type HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kemal.