Giter Site home page Giter Site logo

Comments (15)

github-actions avatar github-actions commented on June 21, 2024

Thank you and congratulations 🎉 for opening your very first issue in keploy

from keploy.

charankamarapu avatar charankamarapu commented on June 21, 2024

@milinddethe15 Why should the testRun show failed if there is no test case that is failed..? Its like the confusion matrix. My opinion is that False positive is better than False negative in this case.

from keploy.

milinddethe15 avatar milinddethe15 commented on June 21, 2024

Why should the test run if there is no test-set

from keploy.

charankamarapu avatar charankamarapu commented on June 21, 2024

Agreed but it should not be an error I guess. It should be just an info log thats it.

from keploy.

milinddethe15 avatar milinddethe15 commented on June 21, 2024

I can't really understand why it shouldn't be error. I guess keploy record must be necessary for keploy test

from keploy.

charankamarapu avatar charankamarapu commented on June 21, 2024

I mean error or failure in a command signifies that something is wrong either with the application or with keploy or the application cmd etc. But here it is just than user don't have test cases to run. We can just say no test cases found as a warn or info log and exit the cmd. keploy record must be necessary for keploy test this statement is not completely true because you can get test cases from someone who using the same app and just run the test cmd and it will work.

from keploy.

milinddethe15 avatar milinddethe15 commented on June 21, 2024

Yes you are right.
By the Error I meant the same. It should log and exit.
Sorry for this confusion.

from keploy.

charankamarapu avatar charankamarapu commented on June 21, 2024

no problem

from keploy.

nehagup avatar nehagup commented on June 21, 2024

@milinddethe15 are you working on fixing this issue?

from keploy.

milinddethe15 avatar milinddethe15 commented on June 21, 2024

Yes.. I am working on this.

from keploy.

Akash-Singh04 avatar Akash-Singh04 commented on June 21, 2024

Hello @milinddethe15 if you are not currently working on this, i have a proposed solution to this issue.

Before executing the keploy test command,we should implement a check to verify if the project has any test sets recorded within keploy.
If no test sets are found, we can provide an informative error message indicating that there are no test sets available for the project. This message should guide users on how to set up test sets or inform them about the absence of recorded tests.

very importantly, a documentation update would be necessary that includes information about the necessity of having test sets recorded for the keploy test command to function correctly.

I would love to get started on this issue asap, if i can be assigned the same! Thank You

from keploy.

milinddethe15 avatar milinddethe15 commented on June 21, 2024

Hi @Akash-Singh04 , I am working on this and thinking the same approach.
Sorry I am taking time as im new to golang.
If you want you can make PR for the documentation updation.
Thanks for understanding!

from keploy.

Akash-Singh04 avatar Akash-Singh04 commented on June 21, 2024

@nehagup If this issue has been resolved, Kindly close the issue. Otherwise i shall get started on this!

from keploy.

nehagup avatar nehagup commented on June 21, 2024

@charankamarapu does this issue still persist?

from keploy.

Akash-Singh04 avatar Akash-Singh04 commented on June 21, 2024

@nehagup @charankamarapu I just tested and it seems like the issue still persists, keploy test will successfully complete in projects without test sets. I will submit a PR fix for this as soon as possible.

from keploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.