Giter Site home page Giter Site logo

Submit to Google Fonts about dseg HOT 13 OPEN

keshikan avatar keshikan commented on July 3, 2024 7
Submit to Google Fonts

from dseg.

Comments (13)

master-hax avatar master-hax commented on July 3, 2024 2

I have a PR open for Google Fonts: google/fonts#2469

@keshikan good to merge?

from dseg.

keshikan avatar keshikan commented on July 3, 2024 1

@master-hax @MrCsabaToth
Thank you for your support.

from dseg.

MrCsabaToth avatar MrCsabaToth commented on July 3, 2024

That would be sweet

from dseg.

master-hax avatar master-hax commented on July 3, 2024

would definitely appreciate this.

from dseg.

keshikan avatar keshikan commented on July 3, 2024

No problem. Please merge.

from dseg.

MrCsabaToth avatar MrCsabaToth commented on July 3, 2024

Seems like you have to sign a CLA still.

from dseg.

keshikan avatar keshikan commented on July 3, 2024

OK, I signed CLA at May 22, 2020 11:54 PDT.
Is there anything else I should do?

from dseg.

MrCsabaToth avatar MrCsabaToth commented on July 3, 2024

@keshikan Google bot tries to pick up the signed CLA, but it has some problems. @master-hax opened the PR, he has to sign it, but something doesn't align.

If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)?

I also have multiple email addresses, that could be the problem or something else.

from dseg.

MrCsabaToth avatar MrCsabaToth commented on July 3, 2024

Or maybe we should just wait for the bot to take it's turn?

from dseg.

master-hax avatar master-hax commented on July 3, 2024

I did sign it (with my current GitHub username) but maybe it wants my personal email in the github commit?

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors.

I am the sender of the pull request AND the author of the only commit...must be that I didn't include my personal email in the commit

from dseg.

master-hax avatar master-hax commented on July 3, 2024

fixed by adding a CLA verified email to the commit. Not sure how to bug someone for a review...also not sure if I should add our names to CONTRIBUTORS or AUTHORS? looks like they have not been touched in a while.

from dseg.

MrCsabaToth avatar MrCsabaToth commented on July 3, 2024

It's green now. Well, I see there are 69 PRs... let's cross our fingers

from dseg.

MrCsabaToth avatar MrCsabaToth commented on July 3, 2024

Well, I'm not sure when it will be merged. Out of the 69 open PRs a lot of them are about new fonts to add :(

from dseg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.