Consider memoization for "parseTemplates" calls

[kettanaito]

Consider memoization for "parseTemplates" calls

[kettanaito]

Eventually, need to make sure we are memoizing a proper thing. The logic cannot be based on the input props in getAreasList, since a change in props doesn't guarantee the change in the template-* prop values.

Suggestions

1. Perform filterTemplates(props). Takes in a props object, returns an object of template-* props.
2. Invoke getAreasList(templateProps) with the result of filterTemplates function call (that means accepts only template-* props at the first place). Can be memoized based on the template props received.

Pros:

• getAreasList has narrower input scale and can be memoized

Cons:

• There is going to be a small iteration overlap equal to templatePropsLength, because both filterTemplate and getAreasList will iterate over a defined set of template props.

[kettanaito]

This will have no performance effect whatsoever if parseTemplates is called in the constructor method. Moving parseTemplates into another lifecycle method is not desired as well, since layout declaration is not something you change during the component's lifecycle.

I would put this optimization task on hold unless there is a known performance issue.

[kettanaito]

At the moment I see no reason to provide this optimization. Feel free to post some examples when dynamic layout ares would be applicable, but in my opinion this is something that is not meant to change during the component's lifecycle.

Closing for now.