Giter Site home page Giter Site logo

Comments (5)

kevin1024 avatar kevin1024 commented on May 17, 2024

Not sure if this is a problem with the HTTPS implementation in vcrpy or the boto implementation specifically

Probably an issue with VCR, it works by monkeypatching out the httplib stuff with its own VCRHTTPSConnection, which might not implement the (bizarre) stdlib API 100% correctly.

VCRHTTPSConnection instance has no attribute '_vcr_request'

This tells me that since the _vcr_request doesn't exist on the stubbed out connection, Boto is probably calling send())) without calling request() first, so the connection object doesn't exist yet.

send() probably needs to check and if self._vcr_request.body doesn't exist yet, maybe initialize it by calling request() first. Except... send() doesn't give us the host it's connecting to. So how does httplib know which host to connect to?

Just of the top of my head, I don't have time to look into this too deeply right now :)

from vcrpy.

kevin1024 avatar kevin1024 commented on May 17, 2024

After looking into this a bit futher, I think this is caused by Boto's reuse of the existing HTTP connection (keepalive). This breaks some of my assumptions I made when designing the mock.

from vcrpy.

kevin1024 avatar kevin1024 commented on May 17, 2024

I think there might also be an issue with the signature process and timestamps, might need to mock out the time too. Yikes :)

from vcrpy.

kevin1024 avatar kevin1024 commented on May 17, 2024

Actually the timestamp thing can be solved with a customer marcher that ignores the Date header.

from vcrpy.

kevin1024 avatar kevin1024 commented on May 17, 2024

OK, this should be fixed in master, give it a try and let me know if/how it works for you.

from vcrpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.