Use the bs1770gain defaults + true peak

[kevinlekiller]

Use the bs1770gain defaults + true peak

[kevinlekiller]

Alright, not too aware of the specs, that was something I was wondering about, thanks.

[kevinlekiller]

I think the issue with not setting --ebu is if bsgain1770 changes the default to something else in the future, the -23db hardcoded in the xml won't be good anymore, unless we parse the value every time the script starts.

[kevinlekiller]

"I also think the range could be calculated, who knows what it's worth, but why not, while we're at it. ;)"

At first I was parsing the range, but I looked at the mpv source and only noticed peak / track was used so I removed it thinking it was useless.

But I agree with you, I think the more info the better.

[WhitePeter]

OK, I can see what you mean. Thought about that too, but I think that is unlikely. Anyway, I think keeping --ebu is actually more robust, as you say.

[kevinlekiller]

I could parse the default out of this this: bs1770gain --help

Which I think is a better idea, I agree with you, sticking with defaults is better if we can.

[WhitePeter]

But then you'd have to "know" the underlying reference loudness. I can see bloat there. ;)

[WhitePeter]

Oh, I see, the reference is also stated in the help.

[WhitePeter]

BTW, do you think this could be done in, say, python? bs1770gain is also provided for Windows. Obviously, running bash scripts there is quite a hassle. Not that I would care too much, I don't use that platform. Just a thought.

[kevinlekiller]

Yeah, although I've not written any python in a few years, so I'd have to catch up.

Then maybe it can be threaded also.

[WhitePeter]

I, myself know very little about python programming, although I did some coding at Checkio. Maybe this is the right size project to get my feet really wet. Thinking... :)

Edit: I think I need a break, my English is getting worse rather quickly.

[kevinlekiller]

Oh yeah, small projects are great to start.

Jetbrains has a free community version of their IDE for python (pycharm), if you're looking for good IDE.

[WhitePeter]

Thanks, I'll check it out.

[kevinlekiller]

Peter just released bs1770gain v0.4.11 with the multi track fixes.

[WhitePeter]

Oh, is it a release already? Just found the beta2 on sourceforge. Thanks for the info and congrats on the credit. :)

[kevinlekiller]

wm4 also pushed to mpv to make album tags optional, I will remove the copying of album tags, since it doesn't make sense to have them now.

[WhitePeter]

On that note, this issue can be closed. ;)