Comments (5)
@tap52384 I would say this is related to the PHP language package as that one assigns the scopes. This package only gives the assigned scopes it's colours. So if you use the debugger, I think it will show you the assigned scopes are not correct...
from monokai.
I'm not sure I understand you mean. Are you saying that the issue is not with this theme, but with a built-in package for Atom? Also, when you mention a debugger, are you talking about a debugger for the Atom text editor itself or something else? If you are referring to a PHP debugger, I'm not using one that integrates with Atom at the moment. I only have the core packages installed.
from monokai.
@tap52384 sorry, I will be a little more verbose π
In the end Atom is build on top of Chromium. So if you press (on OSX) OPTION+CMD+i
it will open the same Developer Tools
as you'll find in the Chrome browser. Once you've done that you can inspect the source HTML generated by all different packages resulting in what you see in Atom.
The language packages (for PHP that would be this package: https://atom.io/packages/language-php) are responsible for assigning scopes to all the different parts that make up the syntax (vars, funcs, consts e.d) and the theme packages (like this package) are then assigning colours to those scopes.
So indeed I'm suggesting this is a problem with the language package as I suspect it doesn't handle this specific (corner) case correctly and so assigns the wrong scopes...
Makes sense?
from monokai.
Yes, that does make sense. Thanks for taking the time to explain. Atom and this theme is awesome. It's because of this theme that I even tried changing from Sublime Text 3 and I'm so glad I did.
from monokai.
@tap52384 I think there already is a issue logged for this with the PHP language package: atom/language-php#52
So closing this one for now, but of course you can always reopen it when the language package part is fixed and you still see the issue.
from monokai.
Related Issues (20)
- canβt choice the theme,it autoly jump to atom dark
- Syntax color is broken since Atom 1.32.0 due to Tree-Sitter integration HOT 5
- Text colors changed to mostly white after recent update HOT 1
- Angle bracket in C++ color not matching
- Wrong color on preprocessing directive. HOT 1
- syntax color looks different on freshly installed atom from other laptop
- Color of syntax keyframes
- Highlight color changed in 0.26 HOT 13
- Invisibles at end of line not showing, cursor not moving HOT 5
- 0.19.0 broke all the text styling in my java files HOT 1
- Monokai syntax color changed after updated HOT 5
- Quotation marks within template strings are red rather than yellow (JavaScript) HOT 2
- Monokai themes broken after package update HOT 1
- Atom 1.17 breaks import
- no styling on latex emph
- Colors Much Brighter After Update
- gutter HOT 1
- theme not change HOT 1
- Why is the theme different from the screenshot? HOT 3
- Syntax highlight on 'let' using 'Javascript with JSX' doesn't work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monokai.