Giter Site home page Giter Site logo

Comments (6)

edeNFed avatar edeNFed commented on July 19, 2024 1

Hi @hnhbwlp this fix will be released in the next version (probably next week)

from opentelemetry-go-instrumentation.

edeNFed avatar edeNFed commented on July 19, 2024

Thank you for the detailed explanation!
I think a good solution may be replacing the following line
https://github.com/keyval-dev/opentelemetry-go-instrumentation/blob/c4799f7d5fbedcd7533daf0e4103449c6ed156e5/pkg/instrumentors/bpf/net/http/server/bpf/probe.bpf.c#L84
with

void* httpReq_ptr = find_context_in_map(ctx_iface, &context_to_http_events);

The method find_context_in_map handles this case precisely, it walks up the context tree until it finds a parent context in the provided map. (you can see similar usage in the gRPC server instrumentor).

Please let me know if this fix works, I'll be happy to merge a fix.

from opentelemetry-go-instrumentation.

ocampeau avatar ocampeau commented on July 19, 2024

Thanks for your reply. Sure, I'll look into that and once I get something working I send a PR.

from opentelemetry-go-instrumentation.

hnhbwlp avatar hnhbwlp commented on July 19, 2024

@edeNFed Is there any new progress on this issue, I have encountered the same problem.

from opentelemetry-go-instrumentation.

mariomac avatar mariomac commented on July 19, 2024

I tried the approach from the PR #48 and it didn't succeed in my case. How get_argument_by_stack is supposed to work in Go 1.17 if the arguments are passed by register?

from opentelemetry-go-instrumentation.

mariomac avatar mariomac commented on July 19, 2024

This fix in the homonymous repo worked for me: open-telemetry/opentelemetry-go-instrumentation#34

from opentelemetry-go-instrumentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.