Buffer overrun

[kgabis]

Buffer overrun

[stuertz]

Upps sorry, Forgot to escape backslahes in the example above:
the right (failing) example line must be:

const char* msg = "Environment: \npid=13232\nhostname=con-js\nALLUSERSPROFILE=C:\\ProgramData\nAPPDATA=C:\\Users\\js\\AppData\\Roaming";

[measuredweighed]

Just a note to say that we're experiencing this issue too. Any string value containing more than one backslash (i.e: test\\) will cause a crash whereas I believe we would expect the value to be escaped like so: test\\\\

[measuredweighed]

Here's some simple code that'll reproduce the issue:

JSON_Value *root_value = json_value_init_object();
JSON_Object *root_object = json_value_get_object(root_value);

char *serialized_string = NULL;
json_object_set_string(root_object, "name", "John \\Smith");
serialized_string = json_serialize_to_string(root_value);
json_free_serialized_string(serialized_string);
json_value_free(root_value);

[stuertz]

Hi NialG,
I edited the tests a bit and could also reproduce this behavior using gcc.
Without calling json_serialize_to_string it works, but i do get an unescaped value, which looks also wrong to me, as you said.
When calling json_serialize_to_string with backslash values I do get a Segmentaion Fault, as on windows...

[kgabis]

Hi, thanks for reporting this bug.
I'm working on the solution, however current "" parsing behavior is correct. This is explained here: http://stackoverflow.com/questions/3807537/why-does-the-jquery-json-parser-need-double-escaping-for-backslashes

[leearmstrong]

What if the raw input actually needs to be \\ then escaping it to \\\\ is correct?

[measuredweighed]

That's good to hear. We actually experienced this crash when trying to serialize a string containing two unescaped backslashes.

Thanks for all of your hardwork. Do you have any idea when we're likely to see a fix?

[kgabis]

In the following days. But as I said, if you need to specify a windows path in a string in your C code then you must use "\\" instead of "\" (if you want it to be parsed as json).

[kgabis]

This should be fixed now (0d5ac45)

[leearmstrong]

It no longer crashes with the example above

JSON_Value *root_value = json_value_init_object();
JSON_Object *root_object = json_value_get_object(root_value);

char *serialized_string = NULL;
json_object_set_string(root_object, "name", "John \\Smith");
serialized_string = json_serialize_to_string(root_value);
json_free_serialized_string(serialized_string);
json_value_free(root_value);

However serialized_string is still null. I would expect it to be escaped to \\\\

[kgabis]

Hi, I've fixed this issue in 4a4cf7d

There's been some confusion, but I shouldn't have been parsing strings when using {set,dotset,replace,append}_string functions. So right now json_object_set_string(root_object, "name", "John \\Smith"); should work (and return JSONSuccess). However json_parse_string("{\"name\":\"John\\ Smith\"}") shouldn't work, as explained here: #26.