Do not use GLOB to add source files with CMake

[khiopsml]

Do not use GLOB to add source files with CMake

[bruno-at-orange]

I suggest to wait a stable source tree before enabling this. GLOB is not recommended but it is very useful during big refactoring.

[folmos-at-orange]

Ok. I thought we had already all the CPP sources in the tree, why it helps in a refactoring? or why it is risky removing the GLOBs?

I'll have the patch ready in any case.

[bruno-at-orange]

Marc is coming soon with few versions and plenty new files

[folmos-at-orange]

From the CMake documentation, this is the reason they do not recommend using GLOBs for source files

Note We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate. The CONFIGURE_DEPENDS flag may not work reliably on all generators, or if a new generator is added in the future that cannot support it, projects using it will be stuck. Even if CONFIGURE_DEPENDS works reliably, there is still a cost to perform the check on every rebuild.

[folmos-at-orange]

Decision:

• We'll keep globs whenever possible. Is more practical
• Most of the time removing the build directory solves any issue.