Giter Site home page Giter Site logo

Comments (5)

felipe-olmos-orange avatar felipe-olmos-orange commented on May 27, 2024

After investigating I found that there is an issue of lack of idempotency due to long lines comments with tabs. This can happen to us when comment code since we use tabs for indenting.

I reproduced the issue, and indeed it requires two or more times to fix.

I propose:

  • To set ReflowComments: false (I tested it and it works)
  • To try to set it back to true once the fix to the issue arrives which will be with clang 17.

from khiops.

marcboulle avatar marcboulle commented on May 27, 2024

That looks ok for me: I just have to add this options in the .clang-format file of my branch?

Otherwise, which extension should be installed in Visual C++?

from khiops.

felipe-olmos-orange avatar felipe-olmos-orange commented on May 27, 2024

That looks ok for me: I just have to add this options in the .clang-format file of my branch?

I will fix this and add the fix to dev, you can then add it yourself to dev-v11 (usually we should rebase, but this double dev setup makes it more difficult for begginners)

Otherwise, which extension should be installed in Visual C++?

In visual studio 2022 is integrated: see https://learn.microsoft.com/en-us/visualstudio/ide/reference/options-text-editor-c-cpp-formatting?view=vs-2022

from khiops.

marcboulle avatar marcboulle commented on May 27, 2024

La solution Visual C++ ne marche pas:
cf. https://stackoverflow.com/questions/72449679/how-to-apply-format-when-saving-in-visual-studio-2022

J'ai essayé la solution proposée en installant l'extension "Format document on Save" (pas la version 2022, qui ne marche pas)
Paramétrage de Visual C++ 2022:

  • menu Extensions/Gérer les extensions
  • rechercher (Ctrl fn E) "Format "`
  • choisir "Format document on save" (pas ... for VS2022, qui ne marche pas)
  • télécharger
  • l'extension sera activée après avoir quitté puis relancé Visual C++ 2022
  • cela marche et le format est automatiquement appliqué à chaque sauvegarde

A documenter dans le wiki

from khiops.

felipe-olmos-orange avatar felipe-olmos-orange commented on May 27, 2024

Fixed in commit e95d159.

from khiops.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.