DecorationNonWritable is not respected

[khronosgroup]

DecorationNonWritable is not respected

[HansKristian-Work]

Hi. Yes, this bug is caused by an old workaround for glslang which is no longer relevant. I've submitted a PR which makes it more robust: #89. --dump-decoration now reports readonly/writeonly as well:

images
=============

 ID 029 : inputTexture (Set : 0) readonly
 ID 086 : outputTexture (Set : 0) writeonly
=============

[gwihlidal]

Thanks for the fix :) I did find an additional issue that I had to track down with this. Manually masking the decoration_flags against DecorationNonWritable works (my example has 0x0000000401000000 & 0x0000000001000000), but Compiler::get_decoration incorrectly returns 0 (silently) for any of the boolean decorations like NonWritable, NonReadable, Coherent, Volatile, etc...

I propose something like the following:
gwihlidal@862a71b

If you like it, I can add the other decorations as well to do the same thing and submit a PR.

Thanks,
Graham

[HansKristian-Work]

Oh ... ye, get_decoration wasn't supposed to be used with boolean values, but I guess it makes sense to allow it. I'd like a default case to return !!(flags & (1 << bit)) or something, same for get_member_decoration.

EDIT: nvm, returning 1 is fine, see review comments.

[HansKristian-Work]

Merged, thanks.